Make "Connectionlink" argument mandatory in start-azVpnConnectionPack…

…etCapture and Stop-AzVpnConnectionPacketCapture (#13208) Force merge as CI passed * finish * add file * add files * Revert "add file" This reverts commit 8080c05. * add files * Update ChangeLog.md Co-authored-by: Yabo Hu <[email protected]> Co-authored-by: Dingmeng Xue <[email protected]>
Azure · Oct 21, 2020 · ca2a601 · ca2a601
1 parent 9f33a5e
commit ca2a601
Show file tree

Hide file tree

Showing 6 changed files with 20 additions and 11 deletions.
diff --git a/src/Network/Network/ChangeLog.md b/src/Network/Network/ChangeLog.md
@@ -27,6 +27,7 @@
     - Added parameter `-SkuTier`
     - Added parameter `-SkuName` and made Sku as Alias for this
     - Removed parameter `-Sku`
+* [Breaking Change] Made `Connectionlink` argument mandatory in `Start-AzVpnConnectionPacketCapture` and `Stop-AzVpnConnectionPacketCapture`
 
 ## Version 3.5.0
 * Added Office365 Policy to VPNSite Resource

diff --git a/src/Network/Network/Cortex/VpnConnection/StartAzVpnConnectionPacketCaptureCommand.cs b/src/Network/Network/Cortex/VpnConnection/StartAzVpnConnectionPacketCaptureCommand.cs
@@ -79,7 +79,7 @@ public class StartAzVpnConnectionPacketCaptureCommand : VpnConnectionBaseCmdlet
         public string FilterData { get; set; }
 
         [Parameter(
-            Mandatory = false,
+            Mandatory = true,
             HelpMessage = "VpnSiteLink Name of Vpn Connection to  start packet capture on Vpn connection.")]
         public string LinkConnectionName { get; set; }
 

diff --git a/src/Network/Network/Cortex/VpnConnection/StopAzVpnConnectionPacketCaptureCommand.cs b/src/Network/Network/Cortex/VpnConnection/StopAzVpnConnectionPacketCaptureCommand.cs
@@ -70,7 +70,7 @@ public class StopAzVpnConnectionPacketCaptureCommand : VpnConnectionBaseCmdlet
         public string ResourceId { get; set; }
 
         [Parameter(
-            Mandatory = false,
+            Mandatory = true,
             HelpMessage = "VpnSiteLink of Vpn Connection to  start packet capture on Vpn connection.")]
         public string LinkConnectionName { get; set; }
 

diff --git a/src/Network/Network/help/Start-AzVpnConnectionPacketCapture.md b/src/Network/Network/help/Start-AzVpnConnectionPacketCapture.md
@@ -15,20 +15,20 @@ Starts Packet Capture Operation on a Vpn Connection.
 ### ByVpnConnectionName (Default)
 ```
 Start-AzVpnConnectionPacketCapture -ResourceGroupName <String> -ParentResourceName <String> -Name <String>
- [-FilterData <String>] [-LinkConnectionName <String>] [-AsJob] [-DefaultProfile <IAzureContextContainer>]
+ [-FilterData <String>] -LinkConnectionName <String> [-AsJob] [-DefaultProfile <IAzureContextContainer>]
  [-WhatIf] [-Confirm] [<CommonParameters>]
 ```
 
 ### ByVpnConnectionObject
 ```
 Start-AzVpnConnectionPacketCapture -InputObject <PSVpnConnection> [-FilterData <String>]
- [-LinkConnectionName <String>] [-AsJob] [-DefaultProfile <IAzureContextContainer>] [-WhatIf] [-Confirm]
+ -LinkConnectionName <String> [-AsJob] [-DefaultProfile <IAzureContextContainer>] [-WhatIf] [-Confirm]
  [<CommonParameters>]
 ```
 
 ### ByVpnConnectionResourceId
 ```
-Start-AzVpnConnectionPacketCapture -ResourceId <String> [-FilterData <String>] [-LinkConnectionName <String>]
+Start-AzVpnConnectionPacketCapture -ResourceId <String> [-FilterData <String>] -LinkConnectionName <String>
  [-AsJob] [-DefaultProfile <IAzureContextContainer>] [-WhatIf] [-Confirm] [<CommonParameters>]
 ```
 
@@ -146,7 +146,7 @@ Type: System.String
 Parameter Sets: (All)
 Aliases:
 
-Required: False
+Required: True
 Position: Named
 Default value: None
 Accept pipeline input: False

diff --git a/src/Network/Network/help/Stop-AzVpnConnectionPacketCapture.md b/src/Network/Network/help/Stop-AzVpnConnectionPacketCapture.md
@@ -15,19 +15,19 @@ Stops Packet Capture Operation on a Vpn connection
 ### ByVpnConnectionName (Default)
 ```
 Stop-AzVpnConnectionPacketCapture -ResourceGroupName <String> -ParentResourceName <String> -Name <String>
- [-LinkConnectionName <String>] -SasUrl <String> [-AsJob] [-DefaultProfile <IAzureContextContainer>] [-WhatIf]
+ -LinkConnectionName <String> -SasUrl <String> [-AsJob] [-DefaultProfile <IAzureContextContainer>] [-WhatIf]
  [-Confirm] [<CommonParameters>]
 ```
 
 ### ByVpnConnectionObject
 ```
-Stop-AzVpnConnectionPacketCapture -InputObject <PSVpnConnection> [-LinkConnectionName <String>]
- -SasUrl <String> [-AsJob] [-DefaultProfile <IAzureContextContainer>] [-WhatIf] [-Confirm] [<CommonParameters>]
+Stop-AzVpnConnectionPacketCapture -InputObject <PSVpnConnection> -LinkConnectionName <String> -SasUrl <String>
+ [-AsJob] [-DefaultProfile <IAzureContextContainer>] [-WhatIf] [-Confirm] [<CommonParameters>]
 ```
 
 ### ByVpnConnectionResourceId
 ```
-Stop-AzVpnConnectionPacketCapture -ResourceId <String> [-LinkConnectionName <String>] -SasUrl <String> [-AsJob]
+Stop-AzVpnConnectionPacketCapture -ResourceId <String> -LinkConnectionName <String> -SasUrl <String> [-AsJob]
  [-DefaultProfile <IAzureContextContainer>] [-WhatIf] [-Confirm] [<CommonParameters>]
 ```
 
@@ -147,7 +147,7 @@ Type: System.String
 Parameter Sets: (All)
 Aliases:
 
-Required: False
+Required: True
 Position: Named
 Default value: None
 Accept pipeline input: False

diff --git a/tools/StaticAnalysis/Exceptions/Az.Network/BreakingChangeIssues.csv b/tools/StaticAnalysis/Exceptions/Az.Network/BreakingChangeIssues.csv
@@ -601,3 +601,11 @@
 "Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.NewAzureFirewallCommand","New-AzFirewall","0","1050","The parameter set 'IpConfigurationParameterValues' for cmdlet 'New-AzFirewall' has been removed.","Add parameter set 'IpConfigurationParameterValues' back to cmdlet 'New-AzFirewall'."
 "Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.SetAzureFirewallCommand","Set-AzFirewall","0","3010","The property 'DNSRequireProxyForNetworkRules' of type 'Microsoft.Azure.Commands.Network.Models.PSAzureFirewall' has been removed.","Add the property 'DNSRequireProxyForNetworkRules' back to type 'Microsoft.Azure.Commands.Network.Models.PSAzureFirewall'."
 "Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.SetAzureFirewallCommand","Set-AzFirewall","0","3010","The property 'DNSRequireProxyForNetworkRules' of type 'Microsoft.Azure.Commands.Network.Models.PSAzureFirewall' has been removed.","Add the property 'DNSRequireProxyForNetworkRules' back to type 'Microsoft.Azure.Commands.Network.Models.PSAzureFirewall'."
+"Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.StopAzVpnConnectionPacketCaptureCommand","Stop-AzVpnConnectionPacketCapture","0","1050","The parameter set 'ByVpnConnectionName' for cmdlet 'Stop-AzVpnConnectionPacketCapture' has been removed.","Add parameter set 'ByVpnConnectionName' back to cmdlet 'Stop-AzVpnConnectionPacketCapture'."
+"Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.StopAzVpnConnectionPacketCaptureCommand","Stop-AzVpnConnectionPacketCapture","0","1050","The parameter set 'ByVpnConnectionObject' for cmdlet 'Stop-AzVpnConnectionPacketCapture' has been removed.","Add parameter set 'ByVpnConnectionObject' back to cmdlet 'Stop-AzVpnConnectionPacketCapture'."
+"Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.StopAzVpnConnectionPacketCaptureCommand","Stop-AzVpnConnectionPacketCapture","0","1050","The parameter set 'ByVpnConnectionResourceId' for cmdlet 'Stop-AzVpnConnectionPacketCapture' has been removed.","Add parameter set 'ByVpnConnectionResourceId' back to cmdlet 'Stop-AzVpnConnectionPacketCapture'."
+"Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.StopAzVpnConnectionPacketCaptureCommand","Stop-AzVpnConnectionPacketCapture","0","1050","The parameter set '__AllParameterSets' for cmdlet 'Stop-AzVpnConnectionPacketCapture' has been removed.","Add parameter set '__AllParameterSets' back to cmdlet 'Stop-AzVpnConnectionPacketCapture'."
+"Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.Cortex.VpnConnection.StartAzVpnConnectionPacketCaptureCommand","Start-AzVpnConnectionPacketCapture","0","1050","The parameter set 'ByVpnConnectionName' for cmdlet 'Start-AzVpnConnectionPacketCapture' has been removed.","Add parameter set 'ByVpnConnectionName' back to cmdlet 'Start-AzVpnConnectionPacketCapture'."
+"Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.Cortex.VpnConnection.StartAzVpnConnectionPacketCaptureCommand","Start-AzVpnConnectionPacketCapture","0","1050","The parameter set 'ByVpnConnectionObject' for cmdlet 'Start-AzVpnConnectionPacketCapture' has been removed.","Add parameter set 'ByVpnConnectionObject' back to cmdlet 'Start-AzVpnConnectionPacketCapture'."
+"Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.Cortex.VpnConnection.StartAzVpnConnectionPacketCaptureCommand","Start-AzVpnConnectionPacketCapture","0","1050","The parameter set 'ByVpnConnectionResourceId' for cmdlet 'Start-AzVpnConnectionPacketCapture' has been removed.","Add parameter set 'ByVpnConnectionResourceId' back to cmdlet 'Start-AzVpnConnectionPacketCapture'."
+"Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.Cortex.VpnConnection.StartAzVpnConnectionPacketCaptureCommand","Start-AzVpnConnectionPacketCapture","0","1050","The parameter set '__AllParameterSets' for cmdlet 'Start-AzVpnConnectionPacketCapture' has been removed.","Add parameter set '__AllParameterSets' back to cmdlet 'Start-AzVpnConnectionPacketCapture'."