Add NotificationHubsTestRunner and replace TestsBaseClass (#18187)

src/NotificationHubs/NotificationHubs.Test/ScenarioTests/NHServiceTests.cs

@@ -15,47 +15,44 @@
 namespace Commands.NotificationHubs.Test
 {
     using Microsoft.WindowsAzure.Commands.ScenarioTest;
-    using Microsoft.Azure.ServiceManagement.Common.Models;
     using Xunit;
     using Xunit.Abstractions;
-    public class NHServiceTests : TestBaseClass
-    {
-        public XunitTracingInterceptor _logger;
+    using Microsoft.Azure.Commands.NotificationHubs.Test.ScenarioTests;
 
-        public NHServiceTests(Xunit.Abstractions.ITestOutputHelper output)
+    public class NHServiceTests : NotificationHubsTestRunner
+    {
+        public NHServiceTests(ITestOutputHelper output) : base(output)
         {
-            _logger = new XunitTracingInterceptor(output);
-            XunitTracingInterceptor.AddToContext(_logger);
         }
 
         [Fact]
         [Trait(Category.AcceptanceType, Category.CheckIn)]
         public void TestCRUDNamespace()
         {
-            RunPowerShellTest(_logger, "Test-CRUDNamespace");
+            TestRunner.RunTestScript("Test-CRUDNamespace");
         }
 
         [Fact]
         [Trait(Category.AcceptanceType, Category.CheckIn)]
         public void TestCRUDNamespaceAuth()
         {
-            RunPowerShellTest(_logger, "Test-CRUDNamespaceAuth");
+            TestRunner.RunTestScript("Test-CRUDNamespaceAuth");
         }
 
         [Fact(Skip = "Need service team to re-record test after changes to the ClientRuntime.")]
         [Trait(Category.AcceptanceType, Category.CheckIn)]
         [Trait("Re-record", "ClientRuntime changes")]
         public void TestCRUDNotificationHub()
         {
-            RunPowerShellTest(_logger, "Test-CRUDNotificationHub");
+            TestRunner.RunTestScript("Test-CRUDNotificationHub");
         }
 
         [Fact(Skip = "Need service team to re-record test after changes to the ClientRuntime.")]
         [Trait(Category.AcceptanceType, Category.CheckIn)]
         [Trait("Re-record", "ClientRuntime changes")]
         public void TestCRUDNHAuth()
         {
-            RunPowerShellTest(_logger, "Test-CRUDNHAuth");
+            TestRunner.RunTestScript("Test-CRUDNHAuth");
         }
     }
 }

src/NotificationHubs/NotificationHubs.Test/ScenarioTests/NotificationHubsTestRunner.cs

@@ -0,0 +1,54 @@
+// ----------------------------------------------------------------------------------
+//
+// Copyright Microsoft Corporation
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+// http://www.apache.org/licenses/LICENSE-2.0
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+// ----------------------------------------------------------------------------------
+
+using System.Collections.Generic;
+using Microsoft.Azure.Commands.TestFx;
+using Xunit.Abstractions;
+
+namespace Microsoft.Azure.Commands.NotificationHubs.Test.ScenarioTests
+{
+    public class NotificationHubsTestRunner
+    {
+        protected readonly ITestRunner TestRunner;
+
+        protected NotificationHubsTestRunner(ITestOutputHelper output)
+        {
+            TestRunner = TestManager.CreateInstance(output)
+                .WithNewPsScriptFilename($"{GetType().Name}.ps1")
+                .WithProjectSubfolderForTests("ScenarioTests")
+                .WithCommonPsScripts(new[]
+                {
+                    @"../AzureRM.Resources.ps1"
+                })
+                .WithNewRmModules(helper => new[]
+                {
+                    helper.RMProfileModule,
+                    helper.GetRMModulePath("Az.NotificationHubs.psd1")
+                })
+                .WithNewRecordMatcherArguments(
+                    userAgentsToIgnore: new Dictionary<string, string>
+                    {
+                        {"Microsoft.Azure.Management.Resources.ResourceManagementClient", "2016-02-01"}
+                    },
+                    resourceProviders: new Dictionary<string, string>
+                    {
+                        {"Microsoft.Resources", null},
+                        {"Microsoft.Features", null},
+                        {"Microsoft.Authorization", null}
+                    }
+                )
+                .Build();
+        }
+    }
+}