Ignore cmdlet check when it doesn't come from assembly file (#13642)

Co-authored-by: Yunchi Wang <[email protected]>
Azure · Dec 2, 2020 · 5c9ad60 · 5c9ad60
1 parent 099b48f
commit 5c9ad60
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/tools/VersionController/Models/VersionMetadataHelper.cs b/tools/VersionController/Models/VersionMetadataHelper.cs
@@ -267,7 +267,7 @@ public Version GetVersionBumpUsingSerialized(bool serialize = true)
             {
                 powershell.AddScript("(Test-ModuleManifest -Path " + outputModuleManifestPath + ").NestedModules");
                 var cmdletResult = powershell.Invoke();
-                nestedModules = cmdletResult.Select(c => c.ToString() + ".dll");
+                nestedModules = cmdletResult.Select(c => c.ToString());
             }
 
             Version versionBump = Version.PATCH;
@@ -290,9 +290,17 @@ public Version GetVersionBumpUsingSerialized(bool serialize = true)
                 }
 
                 requiredModules.Add(outputModuleDirectory);
-                foreach (var nestedModule in nestedModules)
+                foreach (var nestedModuleName in nestedModules)
                 {
+                    // Handcrafted modules assume its nested module always is DLL file. 
+                    var nestedModule = nestedModuleName + ".dll";
                     var assemblyPath = Directory.GetFiles(outputModuleDirectory, nestedModule, SearchOption.AllDirectories).FirstOrDefault();
+
+                    // However we support PSM1, PSD1 other nested module type. Skip this check and we need to use a different design soon.
+                    if(assemblyPath == null)
+                    {
+                        continue;
+                    }
                     var proxy = new CmdletLoader();
                     var newModuleMetadata = proxy.GetModuleMetadata(assemblyPath, requiredModules);
                     var serializedCmdletName = nestedModule + ".json";