Deprecate Azure German Cloud #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyunchi-ms
approved these changes
Sep 27, 2022
isra-fel
approved these changes
Sep 27, 2022
jiasli
reviewed
Jun 27, 2023
| @@ -86,6 +95,7 @@ public static class AzureEnvironmentConstants | |||
| public const string AzureActiveDirectoryEndpoint = "https://login.microsoftonline.com/"; | |||
| public const string ChinaActiveDirectoryEndpoint = "https://login.chinacloudapi.cn/"; | |||
| public const string USGovernmentActiveDirectoryEndpoint = "https://login.microsoftonline.us/"; | |||
| [Obsolete("Microsoft Cloud Germany was closed on October 29th, 2021.")] | |||
There was a problem hiding this comment.
Why is the constant marked as Obsolete instead of being removed if they are not accessible anymore (Azure/azure-cli#23775)?
There was a problem hiding this comment.
This repo contains code that is depended by all the azure powershell modules. It's a general practice to maintain backwards compatibility here. Removing this property would be a binary breaking change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to announcement https://www.microsoft.com/en-us/cloud-platform/germany-cloud-regions, this pull request removes German Cloud from environment list. Related public variables have added obsolete attribute.