Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Template Should Not Contain Blanks test #436

Merged
merged 3 commits into from
Nov 27, 2024
Merged

Remove Template Should Not Contain Blanks test #436

merged 3 commits into from
Nov 27, 2024

Conversation

jfaurskov
Copy link
Contributor

@jfaurskov jfaurskov commented Nov 27, 2024 •
edited
Loading

Overview/Summary

Removes the Template Should Not Contain Blanks test, as discussed with @judyer28

This PR fixes/adds/changes/removes

Changes the validate yaml schema workflow to remove unwanted test

Breaking Changes

N/A

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@jfaurskov jfaurskov changed the title Remove unwanted spaces test Remove Template Should Not Contain Blanks test Nov 27, 2024
@jfaurskov
Copy link
Contributor Author

Validated that test is removed here: https://github.com/Azure/azure-monitor-baseline-alerts/actions/runs/12045908184/job/33585332727.

@jfaurskov jfaurskov marked this pull request as ready for review November 27, 2024 07:54
@jfaurskov jfaurskov requested a review from judyer28 November 27, 2024 07:54
judyer28
judyer28 approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@judyer28 judyer28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@judyer28 judyer28 merged commit 7166584 into Azure:main Nov 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@judyer28 judyer28 judyer28 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jfaurskov @judyer28