Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bryanzab/patterns alz docs update #23

Merged
merged 6 commits into from
Oct 5, 2023

Conversation

bzabber
Copy link
Contributor

@bzabber bzabber commented Oct 4, 2023

Overview/Summary

Updated alert-details.md:
Updated guidance and provided new information on how to download an extract of the alert details.

Policy-Initiatives.md

  • Updated links to .json files to point to the correct locations for each policy definition.

Breaking Changes

None

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

Only a small number of the resources support metric alert rules scoped at the subscription level and the metric alerts would only apply to resources deployed within the same region. The Support for Multiple Resources column to show which resources support metric alerts being scoped at the subscription level. For a complete list of which resources support metrics alert rules scoped at the subscription level click [here](https://learn.microsoft.com/en-us/azure/azure-monitor/alerts/alerts-types#monitor-multiple-resources).

> **NOTE**: There are hidden columns within the table, to scroll across you need to go to the bottom of the table to scroll and this is a limitation within tables in GitHub. If you have any suggestions to improving this expeirence please do get in touch via a PR or raise an issue, thank you.
> **NOTE**: We have tried to make it so that the table doesn't require a lot of side to side scrolling, but it is still a lot of information, we recommended that you click on the specifc alert name which will take you directly to alert details of that alert.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clicking on the specific alert name takes them to the JSON for the policy template, not the alerts details page. Is that what you intended when you said, "will take you directly to the alert details of the alert."?

corrected indentation
changed multiline description to single line per YAML formatting
Copy link
Collaborator

@JoeyBarnes JoeyBarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments inline for changes

Updated Note based on Joey's comment.
Copy link
Contributor Author

@bzabber bzabber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JoeyBarnes Great feedback and I've updated the language in the note.

@JoeyBarnes JoeyBarnes merged commit 6cf2c5a into Azure:main Oct 5, 2023
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants