-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Downloadable GeoJSON Files with Edits + Improved GeoJSON Editor #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o downloadable IMDF zip
nicoleiftekhar
changed the title
Downloadable GeoJSON Files with Edits
Downloadable GeoJSON Files with Edits + Improved GeoJSON Editor
Aug 14, 2024
…diting + popup before deletion
…dits made to building name
yuqi2
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches between levels and layers will save any edits/deletions/additions made to the IMDF model. Once the "Download IMDF" button is clicked, a new zip file will be created by updating the current GeoJSON files with all updated information.
The GeoJSON editor is improved for a better UX. Certain properties (name and category) are editable by users. These edits can then be downloaded when the "Download IMDF" button is clicked. When the name property is changed, the change is automatically set for the label property as well. This change will reflect on the map, but only after an action that refreshes (switching between layers/levels).
When a feature is clicked, the color of the feature changes and stays changed. It can then be unclicked, or another feature can be chosen which will then change the color of that feature to indicate selection and set all other colors to the default.
Edited colors of hover layer to be more in sync with the rest of the conversion tool. Basemap is loaded in as well.