V2 ingest #544
Open
V2 ingest #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohadbitt
reviewed
Jul 21, 2024
azure-kusto-ingest/azure/kusto/ingest/V2/kusto_storage_uploader.py
Outdated
Show resolved
Hide resolved
azure-kusto-ingest/azure/kusto/ingest/V2/kusto_storage_uploader.py
Outdated
Show resolved
Hide resolved
azure-kusto-ingest/azure/kusto/ingest/V2/kusto_storage_uploader.py
Outdated
Show resolved
Hide resolved
| if local_stream is None or len(local_stream) == 0: | ||
| raise KustoUploadError(local_source.name) | ||
| blob_name = local_source.name + "_" + str(local_source.source_id) + "_" + str(local_source.compression_type.name) | ||
| blob_uri = self.upload_blob(blob_name, local_stream, getattr(local_source, "size", None), local_source.source_id).path |
There was a problem hiding this comment.
Lets look together what we do in C# ..
| elif path.lower().endswith(".gz"): | ||
| self.compression_type = CompressionType.GZip | ||
|
|
||
| def data(self) -> bytes: |
There was a problem hiding this comment.
Please check what happens if this is called twice ..
There was a problem hiding this comment.
Doesn't seem to cause a problem
| return (self.compression_type == CompressionType.Uncompressed) and self.format.compressible | ||
|
|
||
| @abstractmethod | ||
| def data(self): |
There was a problem hiding this comment.
Add a return type - and then you can see they return a different type
There was a problem hiding this comment.
Updated them all to match: def data(self) -> IO[AnyStr]:
| def test_upload_source_is_gzip_file(self): | ||
| file_source = FileSource("azure-kusto-ingest/tests/input/dataset.csv.gz", DataFormat.CSV) | ||
| blob_source = self.uploader.upload_local_source(file_source) | ||
| assert blob_source.url.__contains__("dataset.csv") |
There was a problem hiding this comment.
Let's talk aobut how to test that a stream can be uploaded with retries ..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Kusto Uploader for V2 ingest