Fixes #553 (NETMF solution not compiling) #738
Conversation
- add several IFDEF to have the correct usings - implement NETMF methods is Utils class and add it to the NETMF projects - revert changes in SharedAccessSignatureBuilder (the NETMF Sign methods was simply removed) - rework DeliveryAcknowledgement enum for NETMF - fixed bug with IsBodyCalled property in Message class to work in NETMF
|
Hi @josesimoes, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution! TTYL, AZPRBOT; |
| @@ -134,6 +134,36 @@ static string BuildExpiresOn(TimeSpan timeToLive) | |||
| return Convert.ToString(seconds, CultureInfo.InvariantCulture); | |||
| #endif | |||
| } | |||
|
|
|||
| #if NETMF | |||
There was a problem hiding this comment.
Hi @markrad,
Could you please consider adding this commented code block to the code?
When I implemented the NETMF port for HTTP I spent sometime figuring the correct way to use the NETMF native crypto classes. As the comment mentions, it's only usable if the assemblies are compiled with those libs included.
My point is that this should remain in the code for someone building this from the source AND choosing to use the native NETMF crypto libs instead of the managed SHA256 calculation (that takes up flash space and it's less performant).
|
I messed up the GitHub updates and commits on the changes I wanted to propose. I'll just close this and open a new PR. |
Fixes the NETMF build that was completely broken.
projects
was simply removed)