Add connection deviceId and moduleId to incoming messages on Amqp #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myagley
pushed a commit
to Azure/iotedge
that referenced
this pull request
Jun 29, 2018
…qp outgoing messages Outgoing messages for modules should contain ConnectionDeviceId and ConnectionModuleId properties indicating the source of the message. This already works for Mqtt. This PR adds support fo that on Amqp. This also needed a corresponding change on the SDK side, here is the PR for that - Azure/azure-iot-sdk-csharp#537
CIPop
suggested changes
Jun 29, 2018
There was a problem hiding this comment.
Thanks @varunpuranik . As far as I understand this Edge feature never worked before so there is no app-compat breaking change.
Please increase the contract version for iothub\device\src\Microsoft.Azure.Devices.Client.csproj, 1.17.0 (should be 1.17.1 with your changes) by editing \versions.csv.
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Nit: new line at EOF to keep git happy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
masterbranch.Description of the changes
Incoming messages for modules should contain ConnectionDeviceId and ConnectionModuleId properties indicating the source of the message. This already works for Mqtt. This PR adds support fo that on Amqp.