Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make file upload notification callback async and update doc comments #3224

Merged
merged 6 commits into from
Mar 31, 2023
Merged

Make file upload notification callback async and update doc comments #3224

merged 6 commits into from
Mar 31, 2023

Conversation

drwill-ms
Copy link
Contributor

No description provided.

@drwill-ms drwill-ms force-pushed the drwill/file-upload-notification-callbacks branch from 82d10e8 to f8ea9e2 Compare March 31, 2023 00:12
@drwill-ms drwill-ms force-pushed the drwill/file-upload-notification-callbacks branch from 442e66a to 867d334 Compare March 31, 2023 01:30
@drwill-ms drwill-ms force-pushed the drwill/file-upload-notification-callbacks branch from 867d334 to 2de34a1 Compare March 31, 2023 01:32
@drwill-ms
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@drwill-ms drwill-ms merged commit 2816428 into previews/v2 Mar 31, 2023
@drwill-ms drwill-ms deleted the drwill/file-upload-notification-callbacks branch March 31, 2023 16:42
@timtay-microsoft timtay-microsoft mentioned this pull request Apr 6, 2023
Merged
timtay-microsoft added a commit that referenced this pull request Apr 6, 2023
@timtay-microsoft
Unsubscribe from connection loss events when closing service client A…
dd658b0 
…MQP connection (#3237)

There is no reason to notify users that the connection was lost when they are actively trying to close the connection.

I also made the other callbacks in these AMQP using clients work asynchronously just like #3224 did for the file upload notification processor callbacks.
@brycewang-microsoft brycewang-microsoft mentioned this pull request Apr 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patilsnr patilsnr patilsnr approved these changes

@brycewang-microsoft brycewang-microsoft brycewang-microsoft approved these changes

@timtay-microsoft timtay-microsoft Awaiting requested review from timtay-microsoft timtay-microsoft is a code owner

@abhipsaMisra abhipsaMisra Awaiting requested review from abhipsaMisra abhipsaMisra is a code owner

@andyk-ms andyk-ms Awaiting requested review from andyk-ms andyk-ms is a code owner

@tmahmood-microsoft tmahmood-microsoft Awaiting requested review from tmahmood-microsoft tmahmood-microsoft is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drwill-ms @brycewang-microsoft @patilsnr