Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop dependency on the hub service client from the device client #3178

Merged
merged 2 commits into from
Mar 21, 2023
Merged

Drop dependency on the hub service client from the device client #3178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0fc100c
Drop dependency on the hub service client from the device client
brycewang-microsoft Mar 20, 2023
ee38b4c
fixup
brycewang-microsoft Mar 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion iothub/device/src/IotHubClientOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ public IotHubClientOptions(IotHubClientTransportSettings transportSettings)
public string ModelId { get; set; }

/// <summary>
/// The configuration for setting <see cref="OutgoingMessage.MessageId"/> for every message sent by the device or module client instance.
/// The configuration for setting <see cref="TelemetryMessage.MessageId"/> for every message sent by the device or module client instance.
/// </summary>
/// <remarks>
/// The default behavior is that a message Id is sent only if set by the user.
Expand Down
6 changes: 1 addition & 5 deletions iothub/device/src/Microsoft.Azure.Devices.Client.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,13 +55,9 @@
</None>
</ItemGroup>

<!--Project reference dependencies-->
<ItemGroup>
<ProjectReference Include="..\..\service\src\Microsoft.Azure.Devices.csproj" />
brycewang-microsoft marked this conversation as resolved.
Show resolved Hide resolved
</ItemGroup>

<!--Nuget package dependencies-->
<ItemGroup>
<PackageReference Include="Azure.Core" Version="1.26.0" />
brycewang-microsoft marked this conversation as resolved.
Show resolved Hide resolved
<PackageReference Include="MQTTnet" Version="4.1.2.350" />
<PackageReference Include="Microsoft.Azure.Amqp" Version="2.5.12" />
<PackageReference Include="Microsoft.CodeAnalysis.NetAnalyzers" Version="7.0.1-preview1.23061.1">
Expand Down
2 changes: 1 addition & 1 deletion iothub/service/src/Messaging/Models/OutgoingMessage.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ public OutgoingMessage()
}

/// <summary>
/// Creates a telemetry message with the specified payload.
/// Creates a cloud-to-device message with the specified payload.
/// </summary>
/// <remarks>User should treat the input byte array as immutable when sending the message.</remarks>
/// <param name="payload">The payload will be serialized with
Expand Down