Decouple client open-close semaphore from callback subscription semaphore #3135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhipsaMisra
requested review from
drwill-ms,
timtay-microsoft,
andyk-ms,
brycewang-microsoft,
tmahmood-microsoft,
ngastelum-ms,
patilsnr and
schoims
as code owners
drwill-ms
reviewed
Feb 27, 2023
drwill-ms
reviewed
Feb 27, 2023
drwill-ms
reviewed
Feb 27, 2023
drwill-ms
reviewed
Feb 27, 2023
drwill-ms
reviewed
Feb 27, 2023
drwill-ms
reviewed
Feb 27, 2023
abhipsaMisra
force-pushed
the
abmisr/semaphore
branch
from
956a3cf to
dd96a3f
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
abhipsaMisra
force-pushed
the
abmisr/semaphore
branch
from
6da391a to
597ffc6
Compare
drwill-ms
reviewed
Mar 1, 2023
drwill-ms
reviewed
Mar 1, 2023
drwill-ms
reviewed
Mar 1, 2023
drwill-ms
reviewed
Mar 1, 2023
drwill-ms
approved these changes
Mar 1, 2023
Co-authored-by: David R. Williamson <[email protected]>
Co-authored-by: David R. Williamson <[email protected]>
abhipsaMisra
force-pushed
the
abmisr/semaphore
branch
from
7cea5fd to
202dfb0
Compare
abhipsaMisra
force-pushed
the
abmisr/semaphore
branch
from
202dfb0 to
276705a
Compare
drwill-ms
reviewed
Mar 7, 2023
drwill-ms
reviewed
Mar 7, 2023
drwill-ms
reviewed
Mar 7, 2023
drwill-ms
approved these changes
Mar 7, 2023
drwill-ms
reviewed
Mar 7, 2023
drwill-ms
approved these changes
Mar 7, 2023
Co-authored-by: David R. Williamson <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
abhipsaMisra
added a commit
that referenced
this pull request
Mar 8, 2023
* Decouple client open-close semaphore from callback subscription semaphore * Cancel pending operations when CloseAsync() is invoked
abhipsaMisra
added a commit
that referenced
this pull request
Mar 8, 2023
* Decouple client open-close semaphore from callback subscription semaphore * Cancel pending operations when CloseAsync() is invoked
abhipsaMisra
added a commit
that referenced
this pull request
Mar 8, 2023
* Decouple client open-close semaphore from callback subscription semaphore * Cancel pending operations when CloseAsync() is invoked
abhipsaMisra
added a commit
that referenced
this pull request
Mar 8, 2023
* Decouple client open-close semaphore from callback subscription semaphore * Cancel pending operations when CloseAsync() is invoked
abhipsaMisra
added a commit
that referenced
this pull request
Mar 8, 2023
…o LTS (#3148) * fix(iot-dev): Fix bug where client's retry policy applied n^2 times rather than n times (#2209) * Fix synchronization of semaphore in retry delegating handler (#3135) --------- Co-authored-by: timtay-microsoft <[email protected]>
timstewartm
pushed a commit
to timstewartm/azure-iot-sdk-csharp
that referenced
this pull request
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sepmaphores associated with enabling and disabling subscriptions for callbacks should not be dependent on the Semaphore used for opening or closing the client.
The only purpose of the enable-disable events semaphore is to ensure that requests to enable and disable the subscription invoked by parallel threads are executed in a thread-safe manner.