Fix error in test row #3078
Merged
Fix error in test row #3078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schoims
requested review from
drwill-ms,
timtay-microsoft,
abhipsaMisra,
andyk-ms,
brycewang-microsoft,
tmahmood-microsoft,
ngastelum-ms and
patilsnr
as code owners
patilsnr
added a commit
that referenced
this pull request
Mar 1, 2023
* Improve unit test coverages for Devices V2 (#3046) * Add test cases * Add more tests * Add more unit tests * Address comments * Address comments * Address comments * Add unit tests for ConfigurationsClient * remove unused import statements * Add more test cases and address comments * Add a simple message unit test * Npatilsen/improve unit test coverage (#3047) * connection string tests -- connection string to 90+, connection string parser to 85+, sasbuilder to 100 * added clientTwinProperties test * TwinsClient tests up to 92% and 76% * dmcr tests * dcmr part 2 * direct method service request coverage * direct method service request coverage p2 * exponentialretrypolicy * address comments * Improve code coverage DevicesClient V2 (#3073) * Add more unit tests * Address comments * Create new tests * Work in progress * Work in progress * Work in progress * Add more unit tests * Make methods virtual and write more unit test cases * Add more test * Add comment * Rename test case * remove extra line * remove extra line * Address comments * Add comments * Npatilsen improve code coverage 2 (#3063) * iothubserviceclient tests started * iothubservice client part 2 * fixeddelayretrypolicy * extra fixedretry and incrementalretry policy tests * connection properties and sas properties tests * addressed comments * reformatted logic for connection properties hostname * more comments * Fix error (#3078) * added serialized client twins to http response (#3079) * Remove invalid test * Add new unit tests in V2 Devices to improve coverage (#3089) * Add tests for IotHubTokenCredentialProperties and deserialization * Rename tests * work in progress * Work in progress * Work in progress * Add more tests * Added more tests * Fix broken test * Make changes * Make changes * Address comments 1 * Address comments * Address comments * Address comments * Update test method * minor change * add a test * address comments * address comments * Add additional assertion for validation * address comment * fix typo * address comments * remove extra assertions * address comments * Improve code coverage for AMQP Devices V2 (#3099) * Add tests for IotHubTokenCredentialProperties and deserialization * Work in progress * Work in progress * Add more tests * Added more tests * Fix broken test * Make changes * Address comments 1 * Address comments * Address comments * minor change * address comments * address comments * Add additional assertion for validation * remove extra assertions * work in progress * test * work in progress * work in progress * work in progress * Work in progress * Work in progress * Fix * Fix * Fix * Add more tests * Small updates * remove duplicate test file * minor fixes * minor change * Remove unnecessary test case * Address comments * address comments * address pr comments * added subclient test coverage (serviceClient) (#3088) * rebase and digitalTwinsClient tests * digitalTwinsClient bugs fixed * query client tests outlines * query test attempts * scheduled jobs client and retry policy base fix * debugged query client tests * addressed comments p1 * addressed comments p2 * fixes part 2 * fixed retry policy base * fixes p3 * additional comments * made location more realistic * better test names * final comments addressed * Npatilsen/misc files missing tests (#3118) * rebase and digitalTwinsClient tests * digitalTwinsClient bugs fixed * query client tests outlines * query test attempts * scheduled jobs client and retry policy base fix * debugged query client tests * addressed comments p1 * addressed comments p2 * fixes part 2 * fixed retry policy base * new classes p1 * new classes p1 * merge conflict fixes * merge conflict fixes p2 * retry policy base revert * serialize jobrequests * scheduledjobsoptions serialization * queryresponse * addressed comments * addressed comments * nit comments * rebase onto previews/v2 * Delete haproxy.pem * unsealed amqp classes to make mockable * feedback and error fixes * address error message * compiler warning fix * compiler warning fix p2 * fix failing tests --------- Co-authored-by: Sophia Ji Who Choi <[email protected]> Co-authored-by: Sophia Choi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.