Adding RBAC support for provisioning SDK #2262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylanbulfinMS
requested review from
abhipsaMisra,
andyk-ms,
azabbasi,
brycewang-microsoft,
drwill-ms,
jamdavi and
timtay-microsoft
as code owners
dylanbulfinMS
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
drwill-ms
reviewed
Jan 6, 2022
drwill-ms
reviewed
Jan 6, 2022
drwill-ms
reviewed
Jan 6, 2022
drwill-ms
reviewed
Jan 6, 2022
drwill-ms
reviewed
Jan 6, 2022
drwill-ms
reviewed
Jan 6, 2022
drwill-ms
suggested changes
Jan 6, 2022
drwill-ms
reviewed
Jan 7, 2022
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
drwill-ms
reviewed
Jan 10, 2022
drwill-ms
reviewed
Jan 10, 2022
drwill-ms
reviewed
Jan 10, 2022
drwill-ms
reviewed
Jan 10, 2022
drwill-ms
reviewed
Jan 10, 2022
drwill-ms
reviewed
Jan 10, 2022
drwill-ms
reviewed
Jan 10, 2022
drwill-ms
approved these changes
Jan 10, 2022
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
azabbasi
added a commit
that referenced
this pull request
Jan 26, 2022
drwill-ms
pushed a commit
that referenced
this pull request
Feb 1, 2022
This reverts commit 1a0b9de.
dylanbulfinMS
pushed a commit
that referenced
this pull request
Feb 1, 2022
This reverts commit 1a0b9de.
abhipsaMisra
added a commit
that referenced
this pull request
Feb 14, 2022
* feat(shared): Add common resources for convention-based operations * feat(iot-device): Add support for convention-based telemetry operation * feat(iot-device): Add support for convention-based command operations * * feat(iot-device): Add support for convention-based properties operations * feat(iot-device): Add support for convention-based properties operations Co-authored-by: James Davis ⛺️🏔 <[email protected]> * feat(e2e-tests): Add telemetry E2E tests * feat(e2e-tests): Add command E2E tests * fix(iot-device): Updating client property collection to handle no convention * feat(samples): Add thermostat and temperature controller sample * fix(doc, samples): Update API design doc and move SystemTextJson helper to samples * fix(iot-device): Separate out root-level and component-level property addition operations * feat(tests): Add unit tests for ClientPropertyCollection feat(tests): Add unit tests for ClientPropertyCollection Co-authored-by: Abhipsa Misra <[email protected]> * feat(e2e-tests): Add properties E2E tests Co-authored-by: Abhipsa Misra <[email protected]> * feat(e2e-tests): Add fault injection tests for properties operations (#2001) * fix(iot-device, shared, samples): Rename StatusCodes to CommonClientResponseCodes and add a comment to highlight ClientOptions behavior * fix(iot-device): Fix enumerator implementation to return key-value pairs * fix(iot-device): Make ClientOptions.PayloadConvention readonly * fix(shared): Fix from merge conflict * fix(samples): Update the pnp samples readme (#2025) * refactor(samples): Move preview samples to samples repository (#2057) * fix(e2e-tests): Fix file renaming Configutaion to TestConfiguration * refactor(iot-device): Rename property add method * * fix(iot-device): TryGetValue methods should check for the component identifier when applicable and should not throw any exceptions (#2111) * refactor(iot-device): Separate client reported properties into a separate accessor * fix(iot-device): Add checks to verify that client property update response has version and requestId (#2115) * refactor(iot-device): Update the internal method names as per functionality * feat(iot-device): Add convenience method for acknowledging writable property update requests * fix(iot-device): Update PayloadCollection to accept dictionary of values (#2171) * refactor(iot-device): Merge flows for twin and client property operations (#2180) * fix(e2e-tests): Update E2E tests to initialize and dispose resources correctly * doc(client, service): Update documents about the Proxy property for various clients (#2248) Update our code docs to better explain proxy settings * Cleanup IDE warnings. From 442 down to 31. (#2254) * Fix documented exception types thrown by methods in device client. (#2256) * (Fix: DeviceClient): Fix the concurrency issue in MQTT stack (#2234) * Update RegistryManager bulk API unit tests (#2258) * feat(hub-svc): add support and tests for configurations export (#2250) * Temporarily disable import devices/configs test (#2263) * fix(iot-svc): update debug assert (#2264) * fix(iot-svc): update debug assert * Temporarily disable import devices/configs test (#2263) * fix(iot-svc): update debug assert * Reduce modules in ModulesClient_GetModulesOnDevice to 2 * Consolidate keyvault writes, and fix error about null (#2266) * Cleanup code in Hub RTAC (#2268) * fix(deviceClient): Fix issue with AMQP connection pool and TokenReferesher disposal. (#2260) * Fix issue with AMQP connection pool * Dispose the connection holder appropriately * Add unit testing capability to connection pool * Move more LA steps under conditional (#2270) * Disable import/export of config until bug fix (#2273) * Adding RBAC support for provisioning SDK (#2262) * Added types for different credentials * Altered code to work with new types * Fixed Managers * removed unneeded #if !NET451 * Filled in method summaries * refactored GetHeaderProvider * Added documentation * Formatting fixes to address comments * Adding Common 0.7.1 (#2272) * Fix doc comment list bullets (#2275) * Fix doc comment list bullets * Change to use description tag * sdl(all): Create SBOM for net packages (#2261) * Streamline an RBAC test (#2274) * Exclude low pri .net targets in PR builds (#2277) * fix(tests): Fix device client test to use updated API * Update IDeviceIdentity interface to add doc comments. (#2282) * PnP doc comment updates (#2278) * Fix remaining doc comment bullets (#2285) * Give e2e appId permission on the DPS instance (#2283) * fix(DeviceClient): Avoid NRE after client dispose (#2286) * refactor(iot-device): Update API surface for property callback API * refactor(iot-device): Update API surface for command callback API * fix(e2e-tests): Update E2E tests to use fluent assertions * fix(iot-device): Update API surface to remove redundant private setters * Revert "Adding RBAC support for provisioning SDK (#2262)" (#2289) This reverts commit 7a26eda. * Version bump for 2021-01-26 release (#2291) * Update service clients instantiation doc comments (#2290) * Update RegistryManager instantiation doc comments * Update other service client doc comments. * Fix class field constants casing (#2292) * Disable checks for config in import e2e test (#2293) * Update iteration path in vsts.yaml (#2296) Co-authored-by: James Davis ⛺️🏔 <[email protected]> Co-authored-by: jamdavi <[email protected]> Co-authored-by: Azad Abbasi <[email protected]> Co-authored-by: David R. Williamson <[email protected]> Co-authored-by: dylanbulfinMS <[email protected]>
dylanbulfinMS
added a commit
that referenced
this pull request
Mar 3, 2022
* Revert "Revert "Adding RBAC support for provisioning SDK (#2262)"" This reverts commit 1a0b9de. * Revert "Revert "Adding RBAC support for provisioning SDK (#2262)"" This reverts commit 1a0b9de. * Basic test layout * API update * Style updates * Fix namespace issue * Misc cleanup * Added new field * Reverted e2e script changes * Changing <code> to <c> * Replaced the rest * Updating ArgumentException arguments * Removed digital twin comments * Revert "Added new field" This reverts commit 60a3475. * Added URL encoding * Added a few comments * Fixed syntax error Co-authored-by: Azad Abbasi <[email protected]> Co-authored-by: David R. Williamson <[email protected]>
timstewartm
pushed a commit
to timstewartm/azure-iot-sdk-csharp
that referenced
this pull request
May 30, 2024
* Added types for different credentials * Altered code to work with new types * Fixed Managers * removed unneeded #if !NET451 * Filled in method summaries * refactored GetHeaderProvider * Added documentation * Formatting fixes to address comments
timstewartm
pushed a commit
to timstewartm/azure-iot-sdk-csharp
that referenced
this pull request
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
mainbranch.Description of the changes
Reference/Link to the issue solved with this PR (if any)