Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring updates from pnp feature branch to preview #2196

Merged
merged 86 commits into from
Oct 8, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
86 commits
Select commit Hold shift + click to select a range
0405522
feat(shared): Add common resources for convention-based operations
abhipsaMisra May 19, 2021
3bdd814
feat(iot-device): Add support for convention-based telemetry operation
abhipsaMisra May 18, 2021
5285c79
feat(iot-device): Add support for convention-based command operations
abhipsaMisra May 20, 2021
88c2155
* feat(iot-device): Add support for convention-based properties opera…
abhipsaMisra May 21, 2021
fda54b8
feat(e2e-tests): Add telemetry E2E tests
jamdavi May 22, 2021
531f204
feat(e2e-tests): Add command E2E tests
jamdavi May 22, 2021
e2d88e4
fix(iot-device): Updating client property collection to handle no con…
jamdavi May 24, 2021
ecaaaeb
feat(samples): Add thermostat and temperature controller sample
abhipsaMisra May 25, 2021
36125ee
fix(doc, samples): Update API design doc and move SystemTextJson help…
abhipsaMisra May 25, 2021
739a9df
fix(iot-device): Separate out root-level and component-level property…
abhipsaMisra Jun 3, 2021
3c14bcd
feat(tests): Add unit tests for ClientPropertyCollection
jamdavi Jun 4, 2021
ef1df70
feat(e2e-tests): Add properties E2E tests
jamdavi Jun 4, 2021
08dfff3
feat(e2e-tests): Add fault injection tests for properties operations …
abhipsaMisra Jun 5, 2021
50ac3b8
fix(iot-device, shared, samples): Rename StatusCodes to CommonClientR…
abhipsaMisra Jun 5, 2021
63cdbd4
fix(iot-device): Fix enumerator implementation to return key-value pairs
abhipsaMisra Jun 7, 2021
ce9029d
fix(iot-device): Make ClientOptions.PayloadConvention readonly
abhipsaMisra Jun 8, 2021
913b88f
Merge branch 'master' into abmisr/masterToPreviewsPnP
abhipsaMisra Jun 9, 2021
63e8666
fix(shared): Fix from merge conflict
abhipsaMisra Jun 9, 2021
e59b56d
Merge pull request #2023 from Azure/abmisr/masterToPreviewsPnP
abhipsaMisra Jun 10, 2021
59f4a6d
fix(samples): Update the pnp samples readme (#2025)
abhipsaMisra Jun 11, 2021
75034e5
Rename E2ETests.Configuration to TestConfiguration to avoid SDK type …
Jun 18, 2021
dee1dec
Revert "Rename E2ETests.Configuration to TestConfiguration to avoid S…
Jun 18, 2021
4357995
Rename E2ETests.Configuration to TestConfiguration to avoid SDK type …
Jun 18, 2021
ae65121
feat(service): add support for DeviceScope to import/export job
Jun 18, 2021
48dad62
fix(iot-device): Update IoT Hub CONNACK timeout to be 60 seconds
abhipsaMisra Jun 18, 2021
38870d3
feat(provisioning-device, prov-amqp, prov-mqtt, prov-https): Add supp…
timtay-microsoft Jun 21, 2021
464d395
fix(iot-device): Update doc comments for MqttTransportSettings
abhipsaMisra Jun 21, 2021
d46e0f0
Add documentation to repo about which platforms this SDK supports (#2…
timtay-microsoft Jun 22, 2021
6229acc
readme: Update readme to have LTS patch reference
abhipsaMisra Jun 23, 2021
c83a1d5
doc(readme): Updated readme with details on support for device stream…
vinagesh Jun 29, 2021
a2a23d6
fix(iot-device): Update the amqp layer to inspect the inner exception…
abhipsaMisra Jun 29, 2021
be43890
refactor(samples): Move preview samples to samples repository (#2057)
abhipsaMisra Jul 1, 2021
23a24fc
Merge branch 'master' into abmisr/masterToPreviewPnp
abhipsaMisra Jul 1, 2021
72b470b
fix(e2e-tests): Fix file renaming Configutaion to TestConfiguration
abhipsaMisra Jul 1, 2021
50c1d23
Merge pull request #2059 from Azure/abmisr/masterToPreviewPnp
abhipsaMisra Jul 1, 2021
88ddafd
fix(iot-device): Update connection string validation param
abhipsaMisra Jul 2, 2021
a355449
Update team codeowners
Jul 7, 2021
61f2c3f
fix(e2e-tests): Update resource generation script to generate resources
abhipsaMisra Jul 7, 2021
c76a64d
initial changeS (#2060)
bikamani Jul 8, 2021
c1b707c
Adding readme to explain authentication, retry and timeouts in Device…
vinagesh Jul 14, 2021
058035b
refactor(iot-device): Rename property add method
abhipsaMisra Jul 15, 2021
2d2f1eb
Last of error codes documentation (#2110) (#2074)
Jul 19, 2021
762db48
Rename readme per style and update reference (#2113)
Jul 19, 2021
22fb865
* fix(iot-device): TryGetValue methods should check for the component…
abhipsaMisra Jul 20, 2021
35f8f57
refactor(iot-device): Separate client reported properties into a sepa…
abhipsaMisra Jul 20, 2021
fef30ff
fix(iot-device): Add checks to verify that client property update res…
abhipsaMisra Jul 21, 2021
84985f7
refactor(iot-service) Make all clients mockable (#2117)
vinagesh Jul 21, 2021
635da5f
refactor(iot-service): Move direct method request file out of JobClie…
abhipsaMisra Jul 22, 2021
e4bbb1e
refactor(prov-amqp, prov-mqtt, prov-http): Fix timeout tests failing …
timtay-microsoft Jul 23, 2021
4b5e014
fix(tools): Fix readme for ConsoleEventListener usage (#2123)
abhipsaMisra Jul 26, 2021
7ba7f3d
fix(tools): Fix readme for ConsoleEventListener usage
abhipsaMisra Jul 26, 2021
8ae3891
doc(all): Add documentation for the upcoming service TLS changes for …
timtay-microsoft Jul 28, 2021
0f0f9fb
fix(doc): Fix typo is readme
scb01 Aug 2, 2021
1e24ba7
Remove barustum from CODEOWNERS (#2126)
Aug 3, 2021
9ea8b6c
refactor(ado): Update area paths for analyzers pipeline (#2136)
timtay-microsoft Aug 6, 2021
2c3cb73
refactor(tools-logs): Update log capture script to be configurable an…
abhipsaMisra Aug 6, 2021
39baeb8
refactor(iot-device, prov-mqtt): Target new DotNetty version when not…
Aug 9, 2021
41e519b
refactor(doc): Add additional comments to log capture readme
abhipsaMisra Aug 10, 2021
5349c3f
Bump versions for 2021-08-12 release (#2143)
abhipsaMisra Aug 11, 2021
9782be8
fix(readme): Update the LTS support dates readme (#2147)
abhipsaMisra Aug 12, 2021
8f468d0
fix(e2e): get values from create call to avoid timing issues
Aug 24, 2021
bea49ae
Merge branch 'master' into abmisr/masterToPnpPreview
abhipsaMisra Aug 25, 2021
48a31cc
Merge pull request #2156 from Azure/abmisr/masterToPnpPreview
abhipsaMisra Aug 25, 2021
47c2621
refactor(iot-device): Update the internal method names as per functio…
abhipsaMisra Aug 25, 2021
6ec2eb8
refactor(e2e): Remove unnecessary value in keyvault from setup file (…
vinagesh Aug 26, 2021
8772c04
fix(e2e): Fix e2e setup script to choose the correct dps endpoint bas…
vinagesh Aug 26, 2021
4a9eecb
fix(readme): Update readme to specify preview strategy
abhipsaMisra Aug 27, 2021
bd7b2e4
Removing vinagesh from codebase owners list
vinagesh Aug 30, 2021
fc774ff
feat(iot-device): Add convenience method for acknowledging writable p…
abhipsaMisra Aug 31, 2021
9e782d2
fix(iot-device): Fix params passed into ObjectDisposedException
abhipsaMisra Sep 2, 2021
37a68f6
fix(githib): Update github issues template
abhipsaMisra Sep 15, 2021
322b574
Add support for .NET 5 (#2169)
abhipsaMisra Sep 15, 2021
0be2fe7
fix(iot-device): Update PayloadCollection to accept dictionary of val…
abhipsaMisra Sep 20, 2021
3047a24
Wrong reference to Device Streaming Sample (#2173)
Marusyk Sep 22, 2021
1a0fc1c
fix(dps-service): Remove client side validation of x509 CA references…
timtay-microsoft Sep 24, 2021
48163a8
Add Andy to the repos (#2179)
jamdavi Sep 29, 2021
3d19c62
Default Branch update: Update master branch to main. (#2183)
azabbasi Oct 1, 2021
57629ff
fix(iot-serv): Fix bug where device scope and parent scopes set to de…
timtay-microsoft Oct 4, 2021
caf7850
fix(iot-svc): Cleanup and deprecation warning of code in CryptoKeyGen…
Oct 4, 2021
03b7c49
Add XML docs for exceptions that can be thrown by ModuleClient.SendEv…
Marusyk Oct 5, 2021
900717a
refactor(iot-device): Merge flows for twin and client property operat…
abhipsaMisra Oct 7, 2021
78c580a
Merge branch 'main' into abmisr/mergeFromMaster
abhipsaMisra Oct 7, 2021
90622b6
fix(e2e-tests): Update E2E tests to initialize and dispose resources …
abhipsaMisra Oct 7, 2021
469ba65
Merge pull request #2195 from Azure/abmisr/mergeFromMaster
abhipsaMisra Oct 7, 2021
db30729
Merge branch 'previews/pnpApi' into abmisr/pnpTpPreview
abhipsaMisra Oct 8, 2021
7d7bed7
fix
abhipsaMisra Oct 8, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
# Track1 .NET Azure IoT Hub and DPS SDKs

* @drwill-ms @timtay-microsoft @abhipsaMisra @vinagesh @azabbasi @bikamani @barustum @jamdavi
* @drwill-ms @timtay-microsoft @abhipsaMisra @azabbasi @jamdavi @andykwong-ms
18 changes: 9 additions & 9 deletions .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,13 @@ That is definitely something we want to hear about. Please open an issue on gith

## Contribute documentation

For simple markdown files, we accept documentation pull requests submitted against the `master` branch, if it's about existing SDK features.
For simple markdown files, we accept documentation pull requests submitted against the `main` branch, if it's about existing SDK features.
If your PR is about future changes or has changes to the comments in the code itself, we'll treat is as a code change (see the next section).

## Contribute code
Our SDKs are open-source and we do accept pull-requests if you feel like taking a stab at fixing the bug and maybe adding your name to our commit history :) Please mention any relevant issue number in the pull request description, and follow the contributing guidelines [below](#contributing-guidelines).

Pull-requests for code are to be submitted against the `master` branch. We will review the request and once approved we will be running it in our gated build system. We try to maintain a high bar for code quality and maintainability, we insist on having tests associated with the code, and if necessary, additions/modifications to the requirement documents.
Pull-requests for code are to be submitted against the `main` branch. We will review the request and once approved we will be running it in our gated build system. We try to maintain a high bar for code quality and maintainability, we insist on having tests associated with the code, and if necessary, additions/modifications to the requirement documents.

Also, have you signed the [Contribution License Agreement](https://cla.microsoft.com/) ([CLA](https://cla.microsoft.com/))? A friendly bot will remind you about it when you submit your pull-request.

Expand All @@ -44,9 +44,9 @@ sure your plans and ours are in sync :) Just open an issue on github and tag it
1. If the change affects the public API, extract the updated public API surface and submit a PR for review. Make sure you get a signoff before you move to Step 2.
2. Post API surface approval, follow the below guidelines for contributing code:

a) Follow the steps [here](https://github.com/Azure/azure-iot-sdk-csharp/blob/master/doc/devbox_setup.md) for setting up your development environment.
a) Follow the steps [here](https://github.com/Azure/azure-iot-sdk-csharp/blob/main/doc/devbox_setup.md) for setting up your development environment.

b) Follow the [C# Coding Style](https://github.com/Azure/azure-iot-sdk-csharp/blob/master/doc/coding-style.md).
b) Follow the [C# Coding Style](https://github.com/Azure/azure-iot-sdk-csharp/blob/main/doc/coding-style.md).

c) Unit Tests:
We write unit tests for any new function or block of application code that impacts the existing behavior of the code.
Expand All @@ -73,9 +73,9 @@ sure your plans and ours are in sync :) Just open an issue on github and tag it
```
d) E2E Tests:
Any new feature or functionality added must have associated end-to-end tests.
1. Update/ Add the E2E tests [here](https://github.com/Azure/azure-iot-sdk-csharp/tree/master/e2e/test).
2. In case environmental setup required for the application is changed, update the pre-requisites [here](https://github.com/Azure/azure-iot-sdk-csharp/tree/master/e2e/test/prerequisites).
3. Run the E2E test suite and ensure that all the tests pass successfully. You can also test against the [CI script](https://github.com/Azure/azure-iot-sdk-csharp/blob/master/jenkins/windows_csharp.cmd) that is used in our gated build system.
1. Update/ Add the E2E tests [here](https://github.com/Azure/azure-iot-sdk-csharp/tree/main/e2e/test).
2. In case environmental setup required for the application is changed, update the pre-requisites [here](https://github.com/Azure/azure-iot-sdk-csharp/tree/main/e2e/test/prerequisites).
3. Run the E2E test suite and ensure that all the tests pass successfully. You can also test against the [CI script](https://github.com/Azure/azure-iot-sdk-csharp/blob/main/jenkins/windows_csharp.cmd) that is used in our gated build system.

e) Samples:
Add relevant samples to the [Azure IoT Samples for C# Repo](https://github.com/Azure-Samples/azure-iot-samples-csharp). Make sure to add a supporting readme file demonstrating the steps to run the sample.
Expand All @@ -100,7 +100,7 @@ sure your plans and ours are in sync :) Just open an issue on github and tag it
}
}
```
3. Post completion of all of the above steps, create a PR against `master`.
3. Post completion of all of the above steps, create a PR against `main`.

#### Commit Guidelines
We have very precise rules over how our git commit messages can be formatted. This leads to more readable messages that are easy to follow when looking through the project history.
Expand Down Expand Up @@ -130,7 +130,7 @@ If the commit reverts a previous commit, it should begin with `revert:`, followe

**Rebase and Squash**

* Its manadatory to squash all your commits per scope (i.e package). It is also important to rebase your commits on master.
* Its manadatory to squash all your commits per scope (i.e package). It is also important to rebase your commits on `main`.
* Optionally you can split your commits on the basis of the package you are providing code to.

**Type**
Expand Down
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,5 +24,5 @@ Please use your Azure subscription if you need to share any information from you

## Console log of the issue:
<!-- Please share logs as possible, that will help debugging. -->
<!-- See https://github.com/Azure/azure-iot-sdk-csharp/tree/master/tools/CaptureLogs and
<!-- See https://github.com/Azure/azure-iot-sdk-csharp/tree/main/tools/CaptureLogs and
https://github.com/dotnet/corefx/blob/master/Documentation/debugging/windows-instructions.md#traces -->
4 changes: 2 additions & 2 deletions .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ Please follow the instructions and template below to save us time requesting add
4. Include enough information for us to address the bug:
- A detailed description.
- A [Minimal Complete Reproducible Example](https://stackoverflow.com/help/mcve). This is code we can cut and paste into a readily available sample and run, or a link to a project you've written that we can compile to reproduce the bug.
- Console logs (https://github.com/Azure/azure-iot-sdk-csharp/tree/master/tools/CaptureLogs).
- Console logs (https://github.com/Azure/azure-iot-sdk-csharp/tree/main/tools/CaptureLogs).

5. Delete these instructions before submitting the bug.

Expand All @@ -51,5 +51,5 @@ Please be as detailed as possible: which feature has a problem, how often does i
Please remove any connection string information!

## Console log of the issue
Consider setting the DEBUG environment variable to '*'. This will produce a much more verbose output that will help debugging
Follow the instructions [here](https://github.com/Azure/azure-iot-sdk-csharp/tree/main/tools/CaptureLogs) to capture SDK logs.
Don't forget to remove any connection string information!
6 changes: 3 additions & 3 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@ Need support?
-->

## Checklist
- [ ] I have read the [contribution guidelines](https://github.com/Azure/azure-iot-sdk-csharp/blob/master/.github/CONTRIBUTING.md).
- [ ] I have read the [contribution guidelines](https://github.com/Azure/azure-iot-sdk-csharp/blob/main/.github/CONTRIBUTING.md).
- [ ] I added or modified the existing tests to cover the change (we do not allow our test coverage to go down).
- [ ] This pull-request is submitted against the `master` branch.
<!-- If not against master, please add the reason. -->
- [ ] This pull-request is submitted against the `main` branch.
<!-- If not against main, please add the reason. -->

## Description of the changes
<!-- Itemized list of changes. -->
Expand Down
7 changes: 7 additions & 0 deletions azureiot.sln
Original file line number Diff line number Diff line change
Expand Up @@ -72,11 +72,17 @@ EndProject
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution Items", "{719D18A7-E943-461B-B777-0AAEC43916F5}"
ProjectSection(SolutionItems) = preProject
.editorconfig = .editorconfig
configure_tls_protocol_version_and_ciphers.md = configure_tls_protocol_version_and_ciphers.md
device_connection_and_reliability_readme.md = device_connection_and_reliability_readme.md
readme.md = readme.md
supported_platforms.md = supported_platforms.md
test.runsettings = test.runsettings
EndProjectSection
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.Azure.Devices.Shared.Tests", "shared\tests\Microsoft.Azure.Devices.Shared.Tests.csproj", "{CEEE435F-32FC-4DE5-8735-90F6AC950A01}"
EndProject
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "samples", "samples", "{2368415A-9C09-4F47-9636-FDCA4B85C88C}"
EndProject
Global
GlobalSection(SolutionConfigurationPlatforms) = preSolution
Debug|Any CPU = Debug|Any CPU
Expand Down Expand Up @@ -184,6 +190,7 @@ Global
{275DEE86-1EEA-47C4-A9C5-797DF20EC8A7} = {3AA089A9-A035-439E-BAF6-C3975A334379}
{8E25CDE3-992D-4942-8C38-51A0D8E8EB70} = {9C260BF0-1CCA-45A2-AAB8-6419291B8B88}
{CEEE435F-32FC-4DE5-8735-90F6AC950A01} = {3AA089A9-A035-439E-BAF6-C3975A334379}
{2368415A-9C09-4F47-9636-FDCA4B85C88C} = {A48437BA-3C5B-431E-9B2F-96C850E9E1A5}
EndGlobalSection
GlobalSection(ExtensibilityGlobals) = postSolution
SolutionGuid = {AF61665D-340A-494B-9705-571456BDC752}
Expand Down
Loading