Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Error Codes] Update PartitionNotFound error code #2075

Merged
merged 4 commits into from
Jul 9, 2021
Merged

[Error Codes] Update PartitionNotFound error code #2075

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3b0f36c
[Error Codes] Update PartitionNotFound error code
jamdavi Jul 9, 2021
90cda25
remove double lines
jamdavi Jul 9, 2021
2203e99
remove double lines
jamdavi Jul 9, 2021
c66c932
Merge branch 'feature/errors-documentation' into jamdavi/PartitionNot…
jamdavi Jul 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions iothub/service/src/Common/Exceptions/ErrorCode.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,8 +148,12 @@ public enum ErrorCode
[Obsolete("This error does not appear to be thrown by the service.")]
[EditorBrowsable(EditorBrowsableState.Never)]
JobNotFound = 404002,

PartitionNotFound = 404003,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take note we had the wrong error code in the first place...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new name for 404003 is CannotModifyImmutableConfigurationContent, in the service file. I don't see it being returned anywhere also, so not adding that code here seems right.


/// <summary>
/// The error is internal to IoT Hub and is likely transient. For more details, see <see href="https://docs.microsoft.com/azure/iot-hub/iot-hub-troubleshoot-error-503003-partitionnotfound">503003 PartitionNotFound</see>.
/// </summary>
PartitionNotFound = 503003, // We do not handle this error code in our SDK
Copy link
Contributor

@drwill-ms drwill-ms Jul 9, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see that the service returns this either. Should we add these attributes too then?

        [Obsolete("This error does not appear to be returned by the service.")]
        [EditorBrowsable(EditorBrowsableState.Never)]


ModuleNotFound = 404010,

// Conflict - 409
Expand Down