Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code cleanup around the Amqp device files #1864

Merged
merged 2 commits into from
Mar 27, 2021
Merged

Code cleanup around the Amqp device files #1864

merged 2 commits into from
Mar 27, 2021

Conversation

drwill-ms
Copy link
Contributor

No description provided.

@drwill-ms drwill-ms force-pushed the drwill/amqp-code-clean branch from 6bbddad to 6532fcb Compare March 26, 2021 22:16
abhipsaMisra
abhipsaMisra approved these changes Mar 26, 2021
View reviewed changes
Copy link
Member

@abhipsaMisra abhipsaMisra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only comment is about the variable names still having the upper case T, but I am not sure if you intended to update those as a part of this PR.
Otherwise, looks good!

@drwill-ms drwill-ms force-pushed the drwill/amqp-code-clean branch from 6532fcb to 9ea8c76 Compare March 26, 2021 22:22
@drwill-ms drwill-ms force-pushed the drwill/amqp-code-clean branch from 9ea8c76 to d2d0769 Compare March 26, 2021 22:32
@drwill-ms
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@drwill-ms drwill-ms enabled auto-merge (squash) March 27, 2021 00:07
@drwill-ms
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@drwill-ms drwill-ms merged commit 7fdd74f into master Mar 27, 2021
@drwill-ms drwill-ms deleted the drwill/amqp-code-clean branch March 27, 2021 22:22
timstewartm pushed a commit to timstewartm/azure-iot-sdk-csharp that referenced this pull request May 30, 2024
Code cleanup around the Amqp device files (Azure#1864)
64e5723
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhipsaMisra abhipsaMisra abhipsaMisra approved these changes

@azabbasi azabbasi azabbasi approved these changes

@barustum barustum barustum approved these changes

@bikamani bikamani Awaiting requested review from bikamani

@jamdavi jamdavi Awaiting requested review from jamdavi

@timtay-microsoft timtay-microsoft Awaiting requested review from timtay-microsoft

@vinagesh vinagesh Awaiting requested review from vinagesh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@drwill-ms @barustum @azabbasi @abhipsaMisra