fix(e2e): Fix some environment variable names for consistency #1849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinagesh
force-pushed
the
vinagesh/scriptupdates
branch
from
3312efc to
b8fb791
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vinagesh
requested review from
abhipsaMisra,
azabbasi,
barustum,
bikamani,
drwill-ms,
jamdavi and
timtay-microsoft
as code owners
vinagesh
changed the title
vinagesh
commented
Mar 22, 2021
| @@ -11,7 +11,7 @@ public static partial class Configuration | |||
| { | |||
| public static partial class IoTHub | |||
| { | |||
| public static string ConnectionString => GetValue("IOTHUB_CONN_STRING_CSHARP"); | |||
| public static string ConnectionString => GetValue("IOTHUB_CONNECTION_STRING"); | |||
There was a problem hiding this comment.
We use this in java already and there is no need for something different in .net. This will make the script cleaner for cross language resource creation.
abhipsaMisra
approved these changes
Mar 22, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
bikamani
approved these changes
Mar 23, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vinagesh
force-pushed
the
vinagesh/scriptupdates
branch
from
b8fb791 to
4e93fbc
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
abhipsaMisra
pushed a commit
that referenced
this pull request
Aug 4, 2021
timstewartm
pushed a commit
to timstewartm/azure-iot-sdk-csharp
that referenced
this pull request
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
masterbranch.Description of the changes
Reference/Link to the issue solved with this PR (if any)
Updated some environment variables to match with the Java pipeline so the script can be reused across languages.