(service-client): Refactor and add sas credential #1786

vinagesh · 2021-02-10T20:48:42Z

Checklist

I have read the contribution guidelines.
I added or modified the existing tests to cover the change (we do not allow our test coverage to go down).
This pull-request is submitted against the master branch.

Description of the changes

Reference/Link to the issue solved with this PR (if any)

vinagesh · 2021-02-10T20:48:50Z

/azp run

azure-pipelines · 2021-02-10T20:49:00Z

Azure Pipelines successfully started running 1 pipeline(s).

vinagesh · 2021-02-10T20:50:00Z

common/src/service/IotHubConnectionString.cs

@@ -14,11 +14,12 @@ namespace Microsoft.Azure.Devices
    /// <summary>
    /// The properties required for authentication to IoT hub using a connection string.
    /// </summary>
-    internal sealed class IotHubConnectionString : IotHubCredential
+    internal sealed class IotHubConnectionString
+        : IotHubConnectionProperties


Renamed the base class to indicate they are connection properties and not credentials.

vinagesh · 2021-02-10T20:50:25Z

common/src/service/IotHubConnectionString.cs

@@ -29,9 +30,6 @@ public IotHubConnectionString(IotHubConnectionStringBuilder builder) : base(buil
            SharedAccessKeyName = builder.SharedAccessKeyName;
            SharedAccessKey = builder.SharedAccessKey;
            SharedAccessSignature = builder.SharedAccessSignature;
-            DeviceId = builder.DeviceId;


These are not needed in the Service Client. It looks like copied over code from Device Client that is unused.

iothub/service/src/IoTHubSasCredential.cs

iothub/service/src/IotHubConnectionProperties.cs

vinagesh · 2021-02-10T20:56:44Z

/azp run

azure-pipelines · 2021-02-10T20:56:53Z

Azure Pipelines successfully started running 1 pipeline(s).

iothub/service/src/IotHubSasCredentialProperties.cs

iothub/service/src/IoTHubSasCredential.cs

iothub/service/src/IotHubTokenCredentialProperties.cs

iothub/service/src/IoTHubSasCredential.cs

vinagesh · 2021-02-10T23:20:08Z

/azp run

azure-pipelines · 2021-02-10T23:20:18Z

Azure Pipelines successfully started running 1 pipeline(s).

vinagesh · 2021-02-10T23:30:41Z

/azp run

azure-pipelines · 2021-02-10T23:30:52Z

Azure Pipelines successfully started running 1 pipeline(s).

* fix: samples readme links were out-of-date (#1784) * fix: samples arguments and remove 1 more dead link (#1785) * fix(readme): Update the location of ConsoleEventListener in our readme * doc(service-client) - Updating readme (#1799) * fix(doc): Update amqp transport exception doc to have detailed description for quota exceeded error mapping * feature(device-client): Make the DeviceClient and ModuleClient extensible (#1802) * doc(service-client): Added extra comments to clarify true and false in dispose (#1805) * feature,fix (device-client) Handle Twin failures using Amqp (#1796) * fix(iot-service): Update xml comments for ServiceClient * fix(iot-device): Update MqttTransportHandler to not use SemaphoreSlim.WaitAsync(TimeSpan, CancellationToken) * fix(iot-device): Update dotnetty task calls to use ConfigureAwait(true) * fix(iot-device): Fix MqttTransportHandler to not await on user supplied C2D callback * IoTHub Exception for Get and Patch Twin failures (#1815) * fix(edge): UnixDomainSocketEndPoint is available in .NET 2.1 and greater (#1816) * UnixDomainSocketEndPoint has been standard since 2.1. Allowing later versions to use the correct class The edge client HSM provider uses UnixDomainSockets (UDS) for communication. Before .NET 2.1 to implement a Unix Socket you had to create your own class to do so. Since 2.1 there has been a native UnixDomainSocketEndPoint class in the runtime. In 2.1 and 3.1 there is no issue. However in 5.0 there are some changes to the way the Socket class handles the native UnixDomainSocketEndPoint class. I didn't dig down extremely deep, but I suspect it's due to the way the endpoint handles the SocketAddress and the string manipulation there seeing as how there is a specific implementation for Windows and for Unix. * feat(e2e) - Enabling soft delete when creating keyvaults (#1820) * fix(e2e) - Change event logging to opt in to specific events only. (#1824) * (service-client): Design for IoT hub AAD authentication * (service-client: Refactor and add implementation for token credential input) (#1781) * (service-client): Refactor and add sas credential (#1786) * (service-client): Add constructors in service client to accept aad and sas tokens. (#1787) * (service-client): Add constructors in registry manager to accept aad and sas tokens. (#1788) * (service-client): Add constructors in job client to accept aad and sas tokens. (#1789) * (service-client): Add constructors to accept aad and sas tokens for digital twins client. (#1790) * fix(service-client): Support for AzureSasCredential for a better user experience (#1797) * doc(service-client): Update readme about the differnt client and operations (#1798) * tests(service-client): E2E tests for aad auth on all our clients (#1800) * test(service-client): Adding e2e tests for sas credential auth for IoT hub. (#1806) * feature(service-client): Adding chaching for aad tokens. (#1807) * fix(service-client)- Add IoT hub token scope. (#1812) Co-authored-by: David R. Williamson <[email protected]> Co-authored-by: Abhipsa Misra <[email protected]> Co-authored-by: bikamani <[email protected]> Co-authored-by: jamdavi <[email protected]>

…#1922) * (service-client): Design for IoT hub AAD authentication * (service-client: Refactor and add implementation for token credential input) (#1781) * (service-client): Refactor and add sas credential (#1786) * (service-client): Add constructors in service client to accept aad and sas tokens. (#1787) * (service-client): Add constructors in registry manager to accept aad and sas tokens. (#1788) * (service-client): Add constructors in job client to accept aad and sas tokens. (#1789) * (service-client): Add constructors to accept aad and sas tokens for digital twins client. (#1790) * fix(service-client): Support for AzureSasCredential for a better user experience (#1797) * doc(service-client): Update readme about the differnt client and operations (#1798) * tests(service-client): E2E tests for aad auth on all our clients (#1800) * test(service-client): Adding e2e tests for sas credential auth for IoT hub. (#1806) * feature(service-client): Adding chaching for aad tokens. (#1807) * fix(service-client)- Add IoT hub token scope. (#1812) * feat(e2e) - Adding azure core and identity event sources. (#1826) * fix(service-client): Fixing the required format for sending aad tokens to the service (#1834) * refactor(service-client): Pass the correct amqp audience based on auth type (#1835) * feat(e2e): Enable tests for IotHub AAD auth (#1861) * feat(e2e): Enable jobs test on pipeline for aad auth (#1867) * fix(service-client): Add default value for transpor type. (#1870) * feat(e2e): Enable aad auth pnp tests now that the service supports it. (#1888) * feat(e2e-setup): Update script to setup required assets for AAD auth tests (#1920) * Fix merge error * Made changes based on PR comments

…Azure#1922) * (service-client): Design for IoT hub AAD authentication * (service-client: Refactor and add implementation for token credential input) (Azure#1781) * (service-client): Refactor and add sas credential (Azure#1786) * (service-client): Add constructors in service client to accept aad and sas tokens. (Azure#1787) * (service-client): Add constructors in registry manager to accept aad and sas tokens. (Azure#1788) * (service-client): Add constructors in job client to accept aad and sas tokens. (Azure#1789) * (service-client): Add constructors to accept aad and sas tokens for digital twins client. (Azure#1790) * fix(service-client): Support for AzureSasCredential for a better user experience (Azure#1797) * doc(service-client): Update readme about the differnt client and operations (Azure#1798) * tests(service-client): E2E tests for aad auth on all our clients (Azure#1800) * test(service-client): Adding e2e tests for sas credential auth for IoT hub. (Azure#1806) * feature(service-client): Adding chaching for aad tokens. (Azure#1807) * fix(service-client)- Add IoT hub token scope. (Azure#1812) * feat(e2e) - Adding azure core and identity event sources. (Azure#1826) * fix(service-client): Fixing the required format for sending aad tokens to the service (Azure#1834) * refactor(service-client): Pass the correct amqp audience based on auth type (Azure#1835) * feat(e2e): Enable tests for IotHub AAD auth (Azure#1861) * feat(e2e): Enable jobs test on pipeline for aad auth (Azure#1867) * fix(service-client): Add default value for transpor type. (Azure#1870) * feat(e2e): Enable aad auth pnp tests now that the service supports it. (Azure#1888) * feat(e2e-setup): Update script to setup required assets for AAD auth tests (Azure#1920) * Fix merge error * Made changes based on PR comments

vinagesh changed the base branch from master to previews/RBAC February 10, 2021 20:49

vinagesh commented Feb 10, 2021

View reviewed changes

iothub/service/src/IoTHubSasCredential.cs Show resolved Hide resolved

vinagesh commented Feb 10, 2021

View reviewed changes

iothub/service/src/IotHubConnectionProperties.cs Outdated Show resolved Hide resolved

vinagesh force-pushed the vinagesh/aadnext branch from 15c6eba to e6e5ca2 Compare February 10, 2021 20:56

vinagesh marked this pull request as ready for review February 10, 2021 20:57

vinagesh requested review from abhipsaMisra, azabbasi, barustum, bikamani, drwill-ms, jamdavi and timtay-microsoft as code owners February 10, 2021 20:57

vinagesh changed the title ~~[Do no review](service-client): Refactor and add sas credential~~ (service-client): Refactor and add sas credential Feb 10, 2021

timtay-microsoft reviewed Feb 10, 2021

View reviewed changes

iothub/service/src/IotHubSasCredentialProperties.cs Outdated Show resolved Hide resolved

timtay-microsoft reviewed Feb 10, 2021

View reviewed changes

iothub/service/src/IoTHubSasCredential.cs Outdated Show resolved Hide resolved

drwill-ms reviewed Feb 10, 2021

View reviewed changes

iothub/service/src/IotHubTokenCredentialProperties.cs Show resolved Hide resolved

drwill-ms reviewed Feb 10, 2021

View reviewed changes

iothub/service/src/IoTHubSasCredential.cs Outdated Show resolved Hide resolved

timtay-microsoft reviewed Feb 10, 2021

View reviewed changes

iothub/service/src/IoTHubSasCredential.cs Outdated Show resolved Hide resolved

vinagesh force-pushed the vinagesh/aadnext branch from e6e5ca2 to 779bd75 Compare February 10, 2021 23:15

(service-client): Refactor and add sas credential

c6c5b5b

vinagesh force-pushed the vinagesh/aadnext branch from 779bd75 to c6c5b5b Compare February 10, 2021 23:29

drwill-ms approved these changes Feb 10, 2021

View reviewed changes

vinagesh merged commit aaecd9a into previews/RBAC Feb 11, 2021

vinagesh deleted the vinagesh/aadnext branch February 11, 2021 00:12

vinagesh added a commit that referenced this pull request Mar 11, 2021

(service-client): Refactor and add sas credential (#1786)

cbc9b3e

vinagesh added a commit that referenced this pull request Mar 22, 2021

(service-client): Refactor and add sas credential (#1786)

189dff2

vinagesh added a commit that referenced this pull request Mar 22, 2021

(service-client): Refactor and add sas credential (#1786)

912167b

vinagesh added a commit that referenced this pull request Mar 22, 2021

(service-client): Refactor and add sas credential (#1786)

d1c7ef7

vinagesh added a commit that referenced this pull request Mar 22, 2021

(service-client): Refactor and add sas credential (#1786)

c500dfb

vinagesh added a commit that referenced this pull request Mar 22, 2021

(service-client): Refactor and add sas credential (#1786)

f9be8e7

vinagesh added a commit that referenced this pull request Mar 23, 2021

(service-client): Refactor and add sas credential (#1786)

bea5581

vinagesh added a commit that referenced this pull request Mar 23, 2021

(service-client): Refactor and add sas credential (#1786)

3b56ee4

vinagesh added a commit that referenced this pull request Mar 24, 2021

(service-client): Refactor and add sas credential (#1786)

1d674dc

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

(service-client): Refactor and add sas credential #1786

(service-client): Refactor and add sas credential #1786

vinagesh commented Feb 10, 2021

vinagesh commented Feb 10, 2021

azure-pipelines bot commented Feb 10, 2021

vinagesh Feb 10, 2021 •

edited

Loading

vinagesh Feb 10, 2021

vinagesh commented Feb 10, 2021

azure-pipelines bot commented Feb 10, 2021

vinagesh commented Feb 10, 2021

azure-pipelines bot commented Feb 10, 2021

vinagesh commented Feb 10, 2021

azure-pipelines bot commented Feb 10, 2021

(service-client): Refactor and add sas credential #1786

(service-client): Refactor and add sas credential #1786

Conversation

vinagesh commented Feb 10, 2021

Checklist

Description of the changes

Reference/Link to the issue solved with this PR (if any)

vinagesh commented Feb 10, 2021

azure-pipelines bot commented Feb 10, 2021

vinagesh Feb 10, 2021 • edited Loading

Choose a reason for hiding this comment

vinagesh Feb 10, 2021

Choose a reason for hiding this comment

vinagesh commented Feb 10, 2021

azure-pipelines bot commented Feb 10, 2021

vinagesh commented Feb 10, 2021

azure-pipelines bot commented Feb 10, 2021

vinagesh commented Feb 10, 2021

azure-pipelines bot commented Feb 10, 2021

vinagesh Feb 10, 2021 •

edited

Loading