Device Streams - API Review Feedback: stream_c2d_* -> prefix these with "IoTHubClient_" and replace underscore-seperate with capital-seperated #900
Assignees
Labels
Comments
jspaith
added
the
public-preview
ewertons
added a commit
that referenced
this issue
Oct 24, 2019
|
Fixed. |
|
@wickste, @ewertons, thank you for your contribution to our open-sourced project! Please help us improve by filling out this 2-minute customer satisfaction survey |
Emil-Juhl
pushed a commit
to Emil-Juhl/azure-iot-sdk-c
that referenced
this issue
Jun 26, 2020
Emil-Juhl
pushed a commit
to Emil-Juhl/azure-iot-sdk-c
that referenced
this issue
Jul 2, 2020
Update readme.md LTS support table for release lts_02_2020 [ACR] Update readme.md LTS support table for release lts_02_2020 [ACR2] Update readme.md LTS support table for release lts_02_2020 Update CocoaPods-Samples.md (Azure#1424) for 1.3.8 LTS release Create CredScanSuppressions.json add CredScanSuppressions.json to build directory for unit tests flags add check for NULL pointer dereference in deviceTwinCallback add check for NULL pointer dereference in deviceTwinCallback add defualt testing string Jbobotek patch mxchip iotz (Azure#1431) * Update setup.sh * Update build.sh * Update .mxchip-ci.yml for Azure Pipelines * Update arduino-esp.yml for Azure Pipelines * Update setup_arduino_libraries.sh * Delete unnecessary .sh, update_sdk_submodule.sh * Update setup_arduino_libraries.sh * Update setup_arduino_libraries.sh Update raspi.yaml for 2 agent concurrency (Azure#1438) * Update raspi.yaml * Update rpi_input.sh * Update raspi.yaml for Azure Pipelines * Update rpi_uart_interface.py Jbobotek esp new sample location (Azure#1444) * Update setup_arduino_libraries.sh * Update arduino-esp.yml * Update rpi_uart_interface.py * Update setup_arduino_libraries.sh * Update arduino-esp.yml for Azure Pipelines * Update esp_arduino_uart_interface.py Update setup_arduino_libraries.sh (Azure#1452) submodule umock update (Azure#1460) * update unit tests for umock aliasing * submodule reference update * update unit tests for umock aliasing * update unit tests for umock aliasing * update unit test for umock aliasing * update unit tests for umock aliasing * update umock register value functions for BINARY_DATA * fix umock aliasing type * update umock register value functions for BINARY_DATA * update umock register value functions for data * update submodule references * fix unit tests * populated BINARY_DATA shell functions * revert to shell functions opt out of codesign (Azure#1457) * opt out of codesign * flip to false * add component governance * Update .mxchip-ci.yml * Update arduino-esp.yml * Update linux_back_compat.yml * Update longhaul.vsts-ci.yml * Update mxchip-nightly-ci.yml * Update raspi.yaml * Update raspi.yaml * Update .mxchip-ci.yml * Update mxchip-nightly-ci.yml * removing skip variable. Co-authored-by: jbobotek <[email protected]> Provisioning client retry after DNS failure (Azure#1455) * Updating c-utility submodule to pull in DNS fix. Fixing provisioning client state check before timing out. Fixing prov client init if no TPM server is available. Fixing sample possible race condition. Adding prov_device_client UTs. Fixing prov_client connected state. Adding prov_device_client_ll UTs. * Update c-utility to 37ce4d98c7685a971ff9bdf6641c4b40d780f4ec. Adding submodule update doc. Malloc to Calloc calls for 0 initialize padding bytes (Azure#1468) * malloc to calloc, fix UTs expected calls * malloc to calloc, fix UTs expected calls * Update submodule references Cap the maximum delay between attemps of reconnection (retry policy) This change caps the maximum delay between attempts of reconnection to thirty seconds. Such constraint applies to the following - Retry policies: IOTHUB_CLIENT_RETRY_LINEAR_BACKOFF, IOTHUB_CLIENT_RETRY_EXPONENTIAL_BACKOFF, IOTHUB_CLIENT_RETRY_EXPONENTIAL_BACKOFF_WITH_JITTER. - Transports: AMQP, AMQP/WS, MQTT, MQTT/WS. This has been a long-time request, and now it aligns with other Azure IoT SDKs (e.g., https://github.com/Azure/azure-iot-sdk-csharp/blob/f65988b6122cd43df32c123d707395d1bb4367b3/iothub/device/src/TransientFaultHandling/RetryStrategy.cs#L43) Change sprintf to snprintf_s Add windows define macro Add blockID range check Cast rand() result to double before arithmetic Update .vsts-ci.yml (Azure#1471) to new agent Update requirements.txt to use new urllib3 (Azure#1474) Add NULL dereference checks Refactor to single return point Fix comment typo fixed lts naming (Azure#1475) Jbobotek patch python docker (Azure#1476) * Update requirements.txt Update requirements.txt (Azure#1483) Update Dockerfile with new openssl (Azure#1487) Fix for memory leak in _GetTwinAsync (gh issue Azure#1478) This bug is in the iothub_client_core.c layer. Tracked by github issue Azure#1478 Add NULL checks Test PR for raspberry pi Cross Compile step (Azure#1462) * Update raspi.yaml * Update .vsts-ci.yml * Update build.sh * Update raspberrypi_c.sh * Update .vsts-ci.yml for Azure Pipelines * Update raspberrypi_c.sh * Update .vsts-ci.yml * Update build.sh * Update raspberrypi_c.sh * Update .vsts-ci.yml for Azure Pipelines * try new buster brown * try access shell wrong include in provision sample (Azure#1489) * wrong include in provision sample * Test PR for raspberry pi Cross Compile step (Azure#1462) * Update raspi.yaml * Update .vsts-ci.yml * Update build.sh * Update raspberrypi_c.sh * Update .vsts-ci.yml for Azure Pipelines * Update raspberrypi_c.sh * Update .vsts-ci.yml * Update build.sh * Update raspberrypi_c.sh * Update .vsts-ci.yml for Azure Pipelines * try new buster brown * try access shell * wrong include in provision sample Co-authored-by: jbobotek <[email protected]> Update c-utility hash b536e0b Update mxchip repos for pulls (Azure#1486) * Update build.sh * Update .mxchip-ci.yml * Update build.sh * Update .mxchip-ci.yml Update mxchip repo stuff (Azure#1513) * Update .mxchip-ci.yml * Update build.sh Submodule update change order of enum for back compat (Azure#1525) Update input.sh and mxchip-ci.yml to load wifi settings every time(Azure#1515) * Update input.sh * Update .mxchip-ci.yml for Azure Pipelines Fixed extension used in leaf certs to be usr_cert extension set from openssl.cnf (Azure#1519) Co-authored-by: Eric Wolz <[email protected]> Update submodules Update release tag formats (Azure#1545) Add ModelID parameter to IoTHub Client (MQTT only) (Azure#1552) In order to support applications building PnP / DigitalTwin clients on the `master` IoTHub API, we need to let them specify their modelId for the MQTT CONNECT packet, which lives in the userName field. This is done via a `DeviceClient_SetOption(handle, OPTION_MODEL_ID, "dtmi:...");`. It must be specified prior to the first CONNECT, since trying to add this or allow it to be changed later will considerably complicate the state management. The only time a modelId will change on a given device/module identity in practice is during firmware updates in any case, which implies a new handle in any case. The modelID parsing feature requires an API version which is still in preview and not deployed worldwide. To account for this, we will use a preview API version if modelId has been specified and otherwise use the existing model ID. This API version split is not long-term desirable; Azure#1547 tracks fixing. Note that this change is MQTT(_WS) only, per decision to only support C device SDK with PnP over MQTT(_WS). Update API version & new test for twin array support (Azure#1539) IoTHub has added support for JSON arrays inside device twins. To enable this, we need to up our API version string. Also extending e2e twin testing to check that arrays are handled correctly. Even though it's all opaque to C SDK not that much extra testing. Update setting_up_vcpkg.md (Azure#1559) Fix for memory leak if destroying device client right after sending Twin reported property update The issue has been reported on github through Azure#1557 Fix message printed in case of connection creation failure (Azure#1569) Add Device Streaming to Azure IoT C SDK Enable Device Streaming E2E tests Revert improvements in initialize_iothub_client (iothub_client_core_ll.c) Update CONSTBUFFER function calls in iothubtransport_amqp_streaming_ut Fixes for device streaming code and tests Fix memory leak on device streaming e2e tests Update device streaming code with macro_utils renamed macros Adding timeouts to device streaming e2e test requests Disable device streaming over websockets tests if using wolfssl Set trusted cert on uws_client to connect to streaming gateway (ds e2e tests) Disable device streaming tests over websockets when using wolfssl Add more logging on device streaming e2e tests (print SGW urls) Update device streaming code to use product info callback Change device streaming proxy sample to chunk outgoing data into up to 64kb WS frames update readme with device streams DEVICE_STREAM_C2D_REQUEST shall be const (GH issue Azure#901) Rename iothub_client_streaming.h (gh Azure#900) Fixes for DeviceStreaming samples (includes gh#820) Fix includes and API version Reverted API version to a working one
Emil-Juhl
pushed a commit
to Emil-Juhl/azure-iot-sdk-c
that referenced
this issue
Jul 2, 2020
Enable Device Streaming E2E tests Revert improvements in initialize_iothub_client (iothub_client_core_ll.c) Update CONSTBUFFER function calls in iothubtransport_amqp_streaming_ut Fixes for device streaming code and tests Fix memory leak on device streaming e2e tests Update device streaming code with macro_utils renamed macros Adding timeouts to device streaming e2e test requests Disable device streaming over websockets tests if using wolfssl Set trusted cert on uws_client to connect to streaming gateway (ds e2e tests) Disable device streaming tests over websockets when using wolfssl Add more logging on device streaming e2e tests (print SGW urls) Update device streaming code to use product info callback Change device streaming proxy sample to chunk outgoing data into up to 64kb WS frames update readme with device streams DEVICE_STREAM_C2D_REQUEST shall be const (GH issue Azure#901) Rename iothub_client_streaming.h (gh Azure#900) Fixes for DeviceStreaming samples (includes gh#820)
Emil-Juhl
pushed a commit
to Emil-Juhl/azure-iot-sdk-c
that referenced
this issue
Jul 2, 2020
Enable Device Streaming E2E tests Revert improvements in initialize_iothub_client (iothub_client_core_ll.c) Update CONSTBUFFER function calls in iothubtransport_amqp_streaming_ut Fixes for device streaming code and tests Fix memory leak on device streaming e2e tests Update device streaming code with macro_utils renamed macros Adding timeouts to device streaming e2e test requests Disable device streaming over websockets tests if using wolfssl Set trusted cert on uws_client to connect to streaming gateway (ds e2e tests) Disable device streaming tests over websockets when using wolfssl Add more logging on device streaming e2e tests (print SGW urls) Update device streaming code to use product info callback Change device streaming proxy sample to chunk outgoing data into up to 64kb WS frames update readme with device streams DEVICE_STREAM_C2D_REQUEST shall be const (GH issue Azure#901) Rename iothub_client_streaming.h (gh Azure#900) Fixes for DeviceStreaming samples (includes gh#820) Fixed incorrect includes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Tracking issue for DeviceStreams API review feedback
Description of the issue:
stream_c2d_* -> prefix these with "IoTHubClient_" and replace underscore-separate with capital-separated
The text was updated successfully, but these errors were encountered: