Change node event hub cardinality #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soninaren
requested changes
Apr 12, 2017
There was a problem hiding this comment.
Have requested a few changes.
Also test the template updates in prod portal.
Follow the steps here https://github.com/Azure/azure-webjobs-sdk-templates#testing-via-azure-functions-portal
Bindings/bindings.json
Outdated
| { | ||
| "name": "cardinality", | ||
| "value": "enum", | ||
| "resource": "EventHub", |
There was a problem hiding this comment.
Remove "resource": "EventHub". This opening blades for resource selection like storage, eventhub connection
Bindings/bindings.json
Outdated
| ], | ||
| "label": "$eventHubTrigger_cardinality_label", | ||
| "help": "$eventHubTrigger_cardinality_help", | ||
| "placeholder": "$selectCardinality" |
There was a problem hiding this comment.
Don't need placeholder. It is only for textbox. This would be a dropdown.
Bindings/bindings.json
Outdated
| "display": "many" | ||
| } | ||
| ], | ||
| "label": "$eventHubTrigger_cardinality_label", |
There was a problem hiding this comment.
Add corresponding values for $eventHubTrigger_cardinality_label and $eventHubTrigger_cardinality_help in resource files.
Here is a sample .
There was a problem hiding this comment.
Didn't show up in the diff, funky.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@soninaren gonna need you on this one, we need to discuss what lights up in the portal / how much of that we want to do :)
resolves #429