Fix lint error #266
Merged
Fix lint error #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Charles-Gagnon
requested review from
lucyzhang929,
chlafreniere and
MaddyDev
as code owners
chlafreniere
approved these changes
Jun 8, 2022
lucyzhang929
approved these changes
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out that pylint by default doesn't scan all subdirectories - it requires you to specify each module folder (folder with an init.py in it) separately.
pylint-dev/pylint#352
I have no idea why this suddenly started failing (or working depending on how you looked at it...) on Linux though. Possibly some updated version of the package or something for Linux only? Not going to dig into that at this moment though.
Luckily there's a helpful package pylint_runner that will do this for us though so switching to use that instead. Now when I run pylint_runner locally I was able to repro the error and fix it.
(also disabled
C0301 - line too longsince that isn't something we really need to care about right now)