-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable source link and deterministic build #193
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JatinSanghvi
commented
Mar 22, 2022
JatinSanghvi
commented
Mar 22, 2022
extension/WebJobs.Extensions.RabbitMQ.Samples/WebJobs.Extensions.RabbitMQ.Samples.csproj
Outdated
Show resolved
Hide resolved
JatinSanghvi
commented
Mar 22, 2022
extension/WebJobs.Extensions.RabbitMQ/Bindings/RabbitMQAsyncCollector.cs
Show resolved
Hide resolved
JatinSanghvi
commented
Mar 22, 2022
extension/WebJobs.Extensions.RabbitMQ/Services/RabbitMQService.cs
Outdated
Show resolved
Hide resolved
JatinSanghvi
commented
Mar 22, 2022
extension/WebJobs.Extensions.RabbitMQ/WebJobs.Extensions.RabbitMQ.csproj
Outdated
Show resolved
Hide resolved
JatinSanghvi
force-pushed
the
codeanalysis
branch
from
April 1, 2022 11:37
61873be
to
fcd4c8d
Compare
JatinSanghvi
commented
Apr 7, 2022
JatinSanghvi
commented
Apr 7, 2022
extension/WebJobs.Extensions.RabbitMQ.Tests/RabbitMQAsyncCollectorTests.cs
Show resolved
Hide resolved
JatinSanghvi
commented
Apr 7, 2022
extension/WebJobs.Extensions.RabbitMQ/Config/RabbitMQExtensionConfigProvider.cs
Show resolved
Hide resolved
v-shenoy
reviewed
Apr 8, 2022
extension/WebJobs.Extensions.RabbitMQ.Tests/RabbitMQClientBuilderTests.cs
Show resolved
Hide resolved
v-shenoy
reviewed
Apr 8, 2022
v-shenoy
approved these changes
Apr 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Below screenshot shows the differences in NuGet package metadata as viewed on NuGet package explorer, between existing package v2.0.0-preview and the future one. Please ignore the version number and repository URL. They will be correctly set when a new tagged release will be created.
.editorconfig
. This is modern way to specify the code quality and style rules.In next PR, the code will be further updated to remove some of the code analysis suppressions that are temporarily added in the .editorconfig file.