Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable source link and deterministic build #193

Merged
merged 4 commits into from
Apr 8, 2022

Conversation

JatinSanghvi
Copy link
Contributor

@JatinSanghvi JatinSanghvi commented Mar 22, 2022

Below screenshot shows the differences in NuGet package metadata as viewed on NuGet package explorer, between existing package v2.0.0-preview and the future one. Please ignore the version number and repository URL. They will be correctly set when a new tagged release will be created.

image

  • Enabled Code Analysis.
  • Replaced ruleset file with .editorconfig. This is modern way to specify the code quality and style rules.
  • Retaining third party analyzer, StyleCop, as it has host of style checks, not available in default .NET analyzers.
  • Updated the code to remove code analysis reported issues.
  • Added icon. I see three different images in use, so picked the one most appropriate in my opinion.

In next PR, the code will be further updated to remove some of the code analysis suppressions that are temporarily added in the .editorconfig file.

@JatinSanghvi JatinSanghvi marked this pull request as ready for review April 1, 2022 11:37
Copy link
Member

@v-shenoy v-shenoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JatinSanghvi JatinSanghvi merged commit ece7476 into Azure:dev Apr 8, 2022
@JatinSanghvi JatinSanghvi deleted the codeanalysis branch April 8, 2022 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants