-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove connection-string elements from attributes #184
Merged
JatinSanghvi
merged 3 commits into
Azure:dev
from
JatinSanghvi:remove-connection-attributes
Feb 21, 2022
Merged
Remove connection-string elements from attributes #184
JatinSanghvi
merged 3 commits into
Azure:dev
from
JatinSanghvi:remove-connection-attributes
Feb 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JatinSanghvi
commented
Feb 17, 2022
JatinSanghvi
commented
Feb 17, 2022
JatinSanghvi
commented
Feb 17, 2022
JatinSanghvi
commented
Feb 17, 2022
JatinSanghvi
commented
Feb 17, 2022
JatinSanghvi
commented
Feb 17, 2022
JatinSanghvi
changed the title
Remove connection-string elements attributes
Remove connection-string elements from attributes
Feb 17, 2022
JatinSanghvi
commented
Feb 17, 2022
JatinSanghvi
commented
Feb 18, 2022
JatinSanghvi
force-pushed
the
remove-connection-attributes
branch
from
February 18, 2022 09:09
5aba790
to
78403aa
Compare
v-shenoy
approved these changes
Feb 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, @JatinSanghvi.
The changes look thorough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current extension supports both RabbitMQ connection URI e.g.
amqp://user:pass@host:10000/vhost
and individual connection-string elements (user
,pass
,host
, and1000
) to be specified in trigger and output bindings. With the latter way to specify connection information, some of the elements were still missing, namely isSslEnabled and vHost. We recently added commit to include attribute property for isSslEnabled. Instead of adding and maintaining these many number of attribute properties, this commit removes the latter support. This would also eliminate combinations like hostname coming from appsettings but port coming from attributes, which is not what we expect from users.As per my research, most of the users use connection strings in their functions. Since next one would be a version 2.x release, I am taking the opportunity to introduce this breaking change. Users using connection strings already are not expected to update their functions to upgrade to v2.x release. The other WebJobs extensions from Azure only support connection strings, as far as I have seen.