Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Backport 4.27: Update function directory in load request to use /home/site/wwwroot #1481

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

gavin-aguiar
Copy link
Contributor

Description

This fixes a bug introduced in #1446.

For function apps using FWPC > 1 and using blueprints, the second worker does not get the metadata request. In the load request, the worker uses the function directory sent from the host. This works for functions apps without blueprints since the func dir is always /home/site/wwwroot. For blueprints, the function dir is /home/site/wwwroot/<blueprint_dir>. So in the load request, the worker tries to find function_app.py in /home/site/wwwroot/<blueprint_dir> and it fails indexing.
Fix is to always use /home/site/wwwroot for v2 programming model

Fixes #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

@gavin-aguiar gavin-aguiar marked this pull request as ready for review April 18, 2024 14:21
Copy link
Member

@vrdmr vrdmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.57%. Comparing base (6a50c07) to head (6c668dd).

Additional details and impacted files
@@                 Coverage Diff                 @@
##           release/4.27.1    #1481       +/-   ##
===================================================
- Coverage           85.23%   31.57%   -53.67%     
===================================================
  Files                  35       35               
  Lines                1998     1986       -12     
  Branches              378      293       -85     
===================================================
- Hits                 1703      627     -1076     
- Misses                219     1358     +1139     
+ Partials               76        1       -75     
Flag Coverage Δ
unittests 31.57% <100.00%> (-53.62%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gavin-aguiar gavin-aguiar merged commit 6427215 into release/4.27.1 Apr 18, 2024
45 of 47 checks passed
@gavin-aguiar gavin-aguiar deleted the gaaguiar/427_hotfix branch April 18, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants