Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update language worker to support parsing command-line arguments prefix with functions-<argumentname> #993

Merged
merged 7 commits into from
Sep 9, 2023

Conversation

Francisco-Gamino
Copy link
Contributor

@Francisco-Gamino Francisco-Gamino commented Sep 8, 2023

Issue describing the changes in this PR

Resolves (1) and (2) for #992
(3) must be done after the Functions Host changes have propagated, and we have a Core Tools version with this new Functions Host.

Changes in this PR:

  • Add support to parsing command-line arguments prefix with functions-<argumentname>
  • Parser to ignore unknown arguments
  • Remove deprecated option grpcMaxMessageLength

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

…-<argumentname>

* Ignore unknown arguments

* Remove deprecated option grpcMaxMessageLength
src/Worker.cs Outdated Show resolved Hide resolved
src/Worker.cs Show resolved Hide resolved
src/Worker.cs Outdated Show resolved Hide resolved
@Francisco-Gamino
Copy link
Contributor Author

Francisco-Gamino commented Sep 8, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

src/Worker.cs Outdated Show resolved Hide resolved
@Francisco-Gamino Francisco-Gamino merged commit 4c6411b into dev Sep 9, 2023
Francisco-Gamino added a commit that referenced this pull request Sep 10, 2023
…ix with functions-<argumentname> (#993)

* Add support to parsing command-line arguments prefix with functions-<argumentname>

* Configure parser to ignore unknown arguments

* Remove deprecated option grpcMaxMessageLength
Francisco-Gamino added a commit that referenced this pull request Sep 10, 2023
…ix with functions-<argumentname> (#993)

* Add support to parsing command-line arguments prefix with functions-<argumentname>

* Configure parser to ignore unknown arguments

* Remove deprecated option grpcMaxMessageLength
Francisco-Gamino added a commit that referenced this pull request Sep 10, 2023
…ix with functions-<argumentname> (#993)

* Add support to parsing command-line arguments prefix with functions-<argumentname>

* Configure parser to ignore unknown arguments

* Remove deprecated option grpcMaxMessageLength
Francisco-Gamino added a commit that referenced this pull request Sep 11, 2023
…ix with functions-<argumentname> (#997)

* Update language worker to support parsing command-line arguments prefix with functions-<argumentname> (#993)

* Populate language worker metadata in init response (#884) 

* Updated subtree from https://github.com/azure/azure-functions-language-worker-protobuf. Tag: v1.5.8-protofile. Commit: 14b2ba5ccb188c160c0f6c519ec1d4521ee36440 (#876)
Francisco-Gamino added a commit that referenced this pull request Sep 11, 2023
…ix with functions-<argumentname> (#993) (#996)

* Add support to parsing command-line arguments prefix with functions-<argumentname>

* Configure parser to ignore unknown arguments

* Remove deprecated option grpcMaxMessageLength
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants