Fix GetUnderlyingType() can't get Type when Type is NestedCollection #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hwangwoosam
changed the title
justinyoo
added
oca-pr
|
Hi team, this issue is affecting our applications. What's the status on this PR please? |
|
Struggling with the same issue. We would love to see that resolved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in Issue #588 when type is Nested Collection, GetUnderlying Method return null.
The picture below reproduces the problem by temporarily implementing class and executing sample code.
Problem
Below is the result of solving the problem by modifying the GetUnderlyingType() and GetSubType() methods.
Result