Support dynamic OpenApiHttpTriggerAuthorization
#435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jul 30, 2022
jackbatzner
force-pushed
the
dynamic-openapiauth
branch
from
7bed8fa
to
208f5a6
Compare
justinyoo
requested changes
Aug 18, 2022
| public static IOpenApiHttpTriggerAuthorization Resolve(Assembly assembly) | ||
| { | ||
| var type = assembly.GetLoadableTypes() | ||
| .SingleOrDefault(p => p.GetInterface("IOpenApiHttpTriggerAuthorization", ignoreCase: true).IsNullOrDefault() == false); |
There was a problem hiding this comment.
This may throw an exception if there are more than one implementation. Like OpenApiConfigurationOptionsIgnoreAttribute, we might need to add this attribute class and filter it.
|
|
||
| namespace Microsoft.Azure.WebJobs.Extensions.OpenApi.FunctionApp.InProc.Configurations | ||
| { | ||
| public class OpenApiHttpTriggerAuthorization : DefaultOpenApiHttpTriggerAuthorization |
There was a problem hiding this comment.
Can we use this as MyOpenApiHttpTriggerAuthorization ?
|
|
||
| namespace Microsoft.Azure.WebJobs.Extensions.OpenApi.FunctionApp.InProc.Configurations | ||
| { | ||
| public class MyOpenApiHttpTriggerAuthorization : DefaultOpenApiHttpTriggerAuthorization |
justinyoo
approved these changes
Aug 22, 2022
justinyoo
added
documentation
Derich367
pushed a commit
to Derich367/azure-functions-openapi-extension
that referenced
this pull request
Aug 31, 2022
Derich367
pushed a commit
to Derich367/azure-functions-openapi-extension
that referenced
this pull request
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #434.
Ready for review @justinyoo