Support dynamic OpenApiConfigurationOptions
#432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: - Move examples into readme files - Update tests
jackbatzner
changed the title
jackbatzner
commented
May 6, 2022
samples/Microsoft.Azure.Functions.Worker.Extensions.OpenApi.FunctionApp.OutOfProc/Program.cs
Show resolved
Hide resolved
samples/Microsoft.Azure.WebJobs.Extensions.OpenApi.FunctionApp.InProc/Startup.cs
Show resolved
Hide resolved
…ConfigurationOptions
jackbatzner
changed the title
justinyoo
requested changes
Jul 26, 2022
There was a problem hiding this comment.
Thanks, @jackbatzner for the long wait! I've left comments for you to take a look and make both in-proc worker and out-of-proc worker consistent.
...crosoft.Azure.Functions.Worker.Extensions.OpenApi/Extensions/OpenApiHostBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Azure.WebJobs.Extensions.OpenApi.Core/Resolvers/OpenApiConfigurationResolver.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Azure.Functions.Worker.Extensions.OpenApi/OpenApiHttpTriggerContext.cs
Outdated
Show resolved
Hide resolved
.../Microsoft.Azure.Functions.Worker.Extensions.OpenApi.Tests/OpenApiHttpTriggerContextTests.cs
Outdated
Show resolved
Hide resolved
.../Microsoft.Azure.Functions.Worker.Extensions.OpenApi.Tests/OpenApiHttpTriggerContextTests.cs
Outdated
Show resolved
Hide resolved
.../Microsoft.Azure.Functions.Worker.Extensions.OpenApi.Tests/OpenApiHttpTriggerContextTests.cs
Outdated
Show resolved
Hide resolved
.../Microsoft.Azure.Functions.Worker.Extensions.OpenApi.Tests/OpenApiHttpTriggerContextTests.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Azure.Functions.Worker.Extensions.OpenApi/OpenApiHttpTriggerContext.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Azure.WebJobs.Extensions.OpenApi.Core/Resolvers/OpenApiConfigurationResolver.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Azure.WebJobs.Extensions.OpenApi.Core/Resolvers/OpenApiConfigurationResolver.cs
Outdated
Show resolved
Hide resolved
jackbatzner
changed the title
OpenApiConfigurationOptions
…functions-openapi-extension into dynamic-openapiconfig
jackbatzner
commented
Aug 2, 2022
src/Microsoft.Azure.WebJobs.Extensions.OpenApi/OpenApiTriggerFunctions.cs
Show resolved
Hide resolved
justinyoo
approved these changes
Aug 8, 2022
There was a problem hiding this comment.
Thanks, @jackbatzner for your contribution! It looks super awesome, and now devs can inject the OpenAPI config options dynamically!
|
Once it's merged, I'll update document that you updated into proper locations respectively. |
justinyoo
added
v1.4.0
enhancement
Derich367
pushed a commit
to Derich367/azure-functions-openapi-extension
that referenced
this pull request
Aug 31, 2022
Derich367
pushed a commit
to Derich367/azure-functions-openapi-extension
that referenced
this pull request
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #430.
Ready for review @justinyoo