Add DoubleObject to test-integration (#143) #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinyoo
requested changes
Sep 14, 2021
There was a problem hiding this comment.
@SoniaComp Thanks for your PR!
I've left a few comments with regards to mainly to take care of the request payload. In addition to that, I was wondering where your test codes are. Would you please add it?
...oft.Azure.WebJobs.Extensions.OpenApi.TestApp/Get_ApplicationJson_DoubleObject_HttpTrigger.cs
Outdated
Show resolved
Hide resolved
...oft.Azure.WebJobs.Extensions.OpenApi.TestApp/Get_ApplicationJson_DoubleObject_HttpTrigger.cs
Outdated
Show resolved
Hide resolved
...oft.Azure.WebJobs.Extensions.OpenApi.TestApp/Get_ApplicationJson_DoubleObject_HttpTrigger.cs
Outdated
Show resolved
Hide resolved
justinyoo
added
oca-pr
Deserve82
suggested changes
Sep 23, 2021
...crosoft.Azure.WebJobs.Extensions.OpenApi.Document.Tests/Post_ApplicationJson_Double_Tests.cs
Outdated
Show resolved
Hide resolved
...crosoft.Azure.WebJobs.Extensions.OpenApi.Document.Tests/Post_ApplicationJson_Double_Tests.cs
Outdated
Show resolved
Hide resolved
Deserve82
approved these changes
Sep 24, 2021
justinyoo
approved these changes
Sep 24, 2021
meanstigerkim
pushed a commit
to meanstigerkim/azure-functions-openapi-extension
that referenced
this pull request
Oct 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I add HttpTrigger about Double Type to the TestApp.
I referenced the Add integration testing for Boolean Object Type (#143) #236 Add DecimalTypeObject to test-integration (#143) #237 .