-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pack] adding AspNetCore Grpc implementation #7543
Conversation
fda56a6
to
40d67f4
Compare
81ab696
to
ed5833e
Compare
ed5833e
to
172f9a2
Compare
Capturing the deps.json failure here so I can comment:
|
First, the easy ones: These are all used already because we run on the 3.1 framework. I confirmed in a running app already.
These are minor version updates (I'm trying to figure out why some of these are listed as Removed/Added rather than Changed):
I think we should explicitly list these as Private just in case anyone happens to be using them in prod:
|
Tagging @Francisco-Gamino as FYI - need to keep a close on E2E integration test results after this PR is merged - to ensure we do not see any issues across language workers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
cc @balag0 - fyi
tagging @vrdmr - for python language worker , @amamounelsayed - for language worker , @alrod - for node language worker , @AnatoliB / @Francisco-Gamino - powershell language worker FYI - please keep a close eye on the logs as this commit starts rolling out |
@pragnagopa -- Ack. Will do. |
This is a revitalization of #6842,
hiding the implementation behind a feature flag.Update -- this is no longer hidden behind a feature flag, but you can use a feature flag to disable and go back to the old Grpc server implementation.