Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supporting WorkloadIdentityCredential in KeyVaultSecretsRespository (in-proc) #10310

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Supporting WorkloadIdentityCredential in KeyVaultSecretsRespository (in-proc) #10310

merged 1 commit into from
Jul 23, 2024

Conversation

mattchenderson
Copy link
Contributor

@mattchenderson mattchenderson commented Jul 19, 2024 •
edited
Loading

(in-proc backport of #10309)

Existing behavior can't be leveraged in CI without secrets or in alternative hosting environments. This PR expands the last fallback option to include WorkloadIdentityCredential.

Pull request checklist

  • Backporting to the in-proc branch is not required
    • Otherwise: Link to backporting PR
  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

@mattchenderson mattchenderson mentioned this pull request Jul 19, 2024
Merged
9 tasks
@mattchenderson mattchenderson changed the title Supporting DefaultAzureCredential in KeyVaulSecretsRespository (in-proc) Supporting DefaultAzureCredential in KeyVaultSecretsRespository (in-proc) Jul 19, 2024
@mattchenderson mattchenderson marked this pull request as ready for review July 19, 2024 23:09
@mattchenderson mattchenderson requested a review from a team as a code owner July 19, 2024 23:09
@mattchenderson mattchenderson changed the title Supporting DefaultAzureCredential in KeyVaultSecretsRespository (in-proc) Supporting WorkloadIdentityCredential in KeyVaultSecretsRespository (in-proc) Jul 20, 2024
@mattchenderson mattchenderson mentioned this pull request Jul 22, 2024
Merged
9 tasks
@mattchenderson mattchenderson merged commit cd592ff into in-proc Jul 23, 2024
10 checks passed
@mattchenderson mattchenderson deleted the mattchenderson/kvdac-in-proc branch July 23, 2024 21:09
eliaslopezgt pushed a commit that referenced this pull request Jul 25, 2024
@mattchenderson @eliaslopezgt
WorkloadIdentityCredential in KVSecretsRepository (#10310)
971ab12
eliaslopezgt added a commit that referenced this pull request Jul 25, 2024
@eliaslopezgt @fabiocav @mattchenderson
Adds missing commits for cherry-pick secret repository tests fix (#10333
d991ffd 
)

* Updating Host CI lease access (#10314)

* Updating Host CI lease access (#10294)

* Fixing Azure Powershell argument configuration (#10307)

* WorkloadIdentityCredential in KVSecretsRepository (#10310)

* Updating secret repository tests (#10317) (#10328)

---------

Co-authored-by: Fabio Cavalcante <[email protected]>
Co-authored-by: Matthew Henderson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabiocav fabiocav fabiocav approved these changes

@jviau jviau jviau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattchenderson @fabiocav @jviau