Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address FunctionsApplicationBuilder.Environment null #2837

Merged
merged 2 commits into from
Nov 11, 2024
Merged

Address FunctionsApplicationBuilder.Environment null #2837

merged 2 commits into from
Nov 11, 2024

Conversation

jviau
Copy link
Contributor

@jviau jviau commented Nov 6, 2024

Issue describing the changes in this PR

resolves #issue_for_this_pr

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Forwards FunctionsApplicationBuilder.Environment to the internal builder environment.

@fabiocav
Copy link
Member

How was this identified? Do we have a test gap?

@fabiocav fabiocav merged commit 9028851 into feature/2.x Nov 11, 2024
27 checks passed
@fabiocav fabiocav deleted the jviau/builder-env branch November 11, 2024 18:10
fabiocav pushed a commit that referenced this pull request Nov 11, 2024
@jviau @fabiocav
Address FunctionsApplicationBuilder.Environment null (#2837)
83da03f 
* Address FunctionsApplicationBuilder.Environment null

* Use correct host builder for environment
fabiocav pushed a commit that referenced this pull request Nov 13, 2024
@jviau @fabiocav
Address FunctionsApplicationBuilder.Environment null (#2837)
b00ea6a 
* Address FunctionsApplicationBuilder.Environment null

* Use correct host builder for environment
fabiocav pushed a commit that referenced this pull request Nov 13, 2024
@jviau @fabiocav
Address FunctionsApplicationBuilder.Environment null (#2837)
d3af654 
* Address FunctionsApplicationBuilder.Environment null

* Use correct host builder for environment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surgupta-msft surgupta-msft surgupta-msft approved these changes

@liliankasem liliankasem liliankasem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jviau @fabiocav @liliankasem @surgupta-msft