Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Service Bus settlement support #1945

Merged
merged 18 commits into from
Oct 19, 2023
Merged

Service Bus settlement support #1945

merged 18 commits into from
Oct 19, 2023

Conversation

JoshLove-msft
Copy link
Member

@JoshLove-msft JoshLove-msft commented Oct 4, 2023 •
edited by liliankasem
Loading

Issue describing the changes in this PR

resolves #1538

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

@JoshLove-msft
Copy link
Member Author

Still need to add tests/samples

@liliankasem
Copy link
Member

I think this all looks good - would love to see some tests and samples added

@JoshLove-msft
Copy link
Member Author

I think this all looks good - would love to see some tests and samples added

Added!

@liliankasem liliankasem merged commit 12e8699 into Azure:main Oct 19, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jviau jviau jviau approved these changes

@jsquire jsquire jsquire left review comments

@fabiocav fabiocav fabiocav approved these changes

@liliankasem liliankasem liliankasem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhance Service Bus binding to enable calling service APIs
5 participants
@JoshLove-msft @liliankasem @jsquire @fabiocav @jviau