Extract Base Image for V4 #551
Conversation
CooperLink
requested review from
ahmelsayed,
anirudhgarg,
balag0,
divyagandhisethi,
pragnagopa and
vrdmr
as code owners
CooperLink
force-pushed
the
u/clink/base_image_v4
branch
from
61a0236
to
c73de0a
Compare
CooperLink
force-pushed
the
u/clink/base_image_v4
branch
from
a2d14ae
to
0327b44
Compare
|
V4 pipeline builds failed - @CooperLink - please take a look |
| @@ -30,6 +32,12 @@ steps: | |||
| continueOnError: false | |||
| env: | |||
| pswd: $(dockerPassword) | |||
|
|
|||
| - bash: | | |||
| ./host/generate-composite.sh -4 node | |||
There was a problem hiding this comment.
How about adding PublishArtifact task for pushing the generated Dockerfile for debugging?
There was a problem hiding this comment.
This is a great idea. I am just not sure how we would publish that artifact or where it should go. The build pipelines should tell us if any images failed building. But, it would be nice to have slightly higher traceability if there was some way to surface that artifact on the pipeline run of build that happens.
There was a problem hiding this comment.
There was a problem hiding this comment.
This is great Tsuyoshi. I think that I can and should use this to produce artifacts during build pipelines for each language. I have captured your comment in an issue on the repo here.
#560
Feels like something that should be addressed in a follow up pr but I agree that it is useful
PR information
Continuation of #516 which is an effort to have all language images rely on a base host image. This effort will simplify updates to the docker images used in production and should reduce the need for large and difficult to parse PRs in this repo.
This PR specifically enables dotnet images and brings the changes verified in v3 over to v4. I also updated the release pipeline to upload a zip file of the dockerfiles generated during a release so that we can trace the contents of each image in prod.