Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BULK] - DocuTune remediation - Sensitive terms with GUIDs (part 12) #1030

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

meganbradley
Copy link
Contributor

Applying sensitive terms with GUID changes as part of Content SFI and outlined in Overview - Writing content securely - Platform Manual. Changes are part of the Microsoft-wide SFI effort. Point of contact: @CelesteDG

DocuTune v1.5.2.0
CorrelationId: ac15aa43-4e2b-437f-ab1c-fdd7e79cd4db

#docutune

@meganbradley
Copy link
Contributor Author

#docutune-review

Copy link
Contributor

Learn Build status updates of commit 679297a:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
azureadps-2.0/AzureAD/migrate/New-AzureADUser.md ❌Error Details

azureadps-2.0/AzureAD/migrate/New-AzureADUser.md

  • Line 28, Column 1: [Error: include-not-found - See documentation] Invalid include link: '~/graphref/api-reference/v1.0/includes/permissions/user-post-users-permissions.md'.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@msewaweru msewaweru closed this Oct 22, 2024
@msewaweru msewaweru reopened this Oct 22, 2024
Copy link
Contributor

Learn Build status updates of commit 679297a:

✅ Validation status: passed

File Status Preview URL Details
azureadps-2.0/AzureAD/Add-AzureADGroupMember.yml ✅Succeeded
azureadps-2.0/AzureAD/Add-AzureADGroupOwner.md ✅Succeeded View (azureadps-2.0)
azureadps-2.0/AzureAD/Add-AzureADGroupOwner.yml ✅Succeeded
azureadps-2.0/AzureAD/Add-AzureADMSApplicationOwner.md ✅Succeeded View (azureadps-2.0)
azureadps-2.0/AzureAD/Add-AzureADMSApplicationOwner.yml ✅Succeeded
azureadps-2.0/AzureAD/Add-AzureADMSScopedRoleMembership.md ✅Succeeded View (azureadps-2.0)
azureadps-2.0/AzureAD/Add-AzureADMSScopedRoleMembership.yml ✅Succeeded
azureadps-2.0/AzureAD/Connect-AzureAD.md ✅Succeeded View (azureadps-2.0)
azureadps-2.0/AzureAD/Connect-AzureAD.yml ✅Succeeded
azureadps-2.0/AzureAD/Get-AzureADApplication.md ✅Succeeded View (azureadps-2.0)
azureadps-2.0/AzureAD/Get-AzureADApplication.yml ✅Succeeded
azureadps-2.0/AzureAD/Get-AzureADApplicationExtensionProperty.md ✅Succeeded View (azureadps-2.0)
azureadps-2.0/AzureAD/Get-AzureADApplicationExtensionProperty.yml ✅Succeeded
azureadps-2.0/AzureAD/Get-AzureADApplicationKeyCredential.md ✅Succeeded View (azureadps-2.0)
azureadps-2.0/AzureAD/Get-AzureADApplicationKeyCredential.yml ✅Succeeded
azureadps-2.0/AzureAD/Get-AzureADApplicationLogo.md ✅Succeeded View (azureadps-2.0)
azureadps-2.0/AzureAD/Get-AzureADApplicationLogo.yml ✅Succeeded
azureadps-2.0/AzureAD/Get-AzureADApplicationOwner.md ✅Succeeded View (azureadps-2.0)
azureadps-2.0/AzureAD/Get-AzureADApplicationOwner.yml ✅Succeeded
azureadps-2.0/AzureAD/Get-AzureADApplicationPasswordCredential.md ✅Succeeded View (azureadps-2.0)

For more details, please refer to the build report.

For any questions, please:

Copy link
Collaborator

@msewaweru msewaweru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some GUIDs have not been updated corrected. See the individual comments at the file level.


ObjectId AppId DisplayName
-------- ----- -----------
ed192e92-84d4-4baf-997d-1e190a81f28e 421599eb-eed7-4988-9b31-02b43a4d37b8 MyNewApp
ed192e92-84d4-4baf-997d-1e190a81f28e 00001111-aaaa-2222-bbbb-3333cccc4444 MyNewApp
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ObjectId GUID not updated.

@@ -20,7 +20,7 @@ examples:
description: |-
This cmdlet returns the Scope role membership object:

AdministrativeUnitId RoleId -------------------------- ------------ c9ab56cc-e349-4237-856e-cab03157a91e 526b7173-5a6e-49dc-88ec-b677a9093709
AdministrativeUnitId RoleId -------------------------- ------------ 00000000-0000-0000-0000-000000000000 00000000-0000-0000-0000-000000000000
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied same GUID for different items.

@@ -35,7 +35,7 @@ $User = Get-AzureADUser -SearchString "<The user that will be an admin on this u

This cmdlet returns the Scope role membership object:

AdministrativeUnitId RoleId -------------------------- ------------ c9ab56cc-e349-4237-856e-cab03157a91e 526b7173-5a6e-49dc-88ec-b677a9093709
AdministrativeUnitId RoleId -------------------------- ------------ 00000000-0000-0000-0000-000000000000 00000000-0000-0000-0000-000000000000
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied same GUID for different items.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants