Add examples in Wiki Commands + minor table format edit #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -215,7 +215,7 @@ def transform_wiki_page_table_output(result): | |||
| def _transform_wiki_page_row(row): | |||
| table_row = OrderedDict() | |||
| table_row['ETag'] = row['eTag'] | |||
| table_row['Git Path'] = row['page']['gitItemPath'] | |||
| table_row['Page Path'] = '\'{}\''.format(row['page']['path']) | |||
There was a problem hiding this comment.
just curious, why are we doing this in table output specifically?
There was a problem hiding this comment.
User needs to use the page path in the command not git item path. So I should have always put this in the table output in the first place. See sample above.
gauravsaralMs
approved these changes
May 10, 2019
ishitam8
approved these changes
May 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure the code is following contribution guidelines in CONTRIBUTING.md