Regression fix for knack config file chaining functionality #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atbagga
changed the title
atbagga
changed the title
ishitam8
approved these changes
May 6, 2019
gauravsaralMs
approved these changes
May 6, 2019
atbagga
force-pushed
the
users/atbagga/configfix
branch
from
f2fff77 to
92b8958
Compare
gauravsaralMs
approved these changes
May 6, 2019
atbagga
changed the title
ishitam8
approved these changes
May 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Configuration read is failing and hence tests were failing since organization and project are set via config in tests
Reason: Breaking change: Knack has introduced the concept of scoped configurations which allows chaining of config files. For back compat they allow not using this feature.
The new setter function added in the same PR if used will handle setting the values such that they can be retrieved using the getter. PR link - microsoft/knack#148
Fix: Used the new knack setter function to be consistent in reading and writing the file using knack
CLIConfig class functions.
Fix 2:
Also making a change to not display the value of environment variables anymore in config list command. Since it might end up displaying secrets set in environment variables.