-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fixes : Handle long list of service connections and Github file checkin failure in pipeline create command #568
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The user will end up seeing a different service endpoint list in CLI and in UI..
If we doing this just to get around friendly_prompt_list issue
then I will suggest the following
- Do a proper fix in friendly_prompt_lis
- Build some kind of loop in friendly_prompt_lis
like end option can be (see more options) basically pagination kind of thing
if endpoint.authorization.scheme == 'InstallationToken': | ||
service_endpoints_choice_list.append('{} {}'.format(endpoint.name, '(Recommended)')) | ||
else: | ||
if (endpoint.authorization.scheme == 'InstallationToken' or |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
get_service_endpoints
in the client takes scheme as a param for filtering... can we use that one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I cannot use that filter here..
Reason: I need all service connections created by me or the ones with auth scheme = installationtoken.
I will still need to pass all auth schemes to get_service_endpoints since I need my service endpoints which may or may not be InstallationToken scheme.
Good catch on the functionality being available though. I had missed that.
We will have to fix the list and I will do that. Here the intention is to actually reduce the options also since we do not want the user to have 400 options to choose from. I have raised an issue to fix the list. #571 |
Bug Fixes in az pipeline create command: