Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing task definition list and show commands #525

Merged
merged 5 commits into from
Apr 9, 2019
Merged

Removing task definition list and show commands #525

merged 5 commits into from
Apr 9, 2019

Conversation

atbagga
Copy link
Collaborator

@atbagga atbagga commented Apr 8, 2019

Removing task definition list and show commands since the APIs are no longer publicly supported.

Please make sure the code is following contribution guidelines in CONTRIBUTING.md

  • : This PR has a corresponding issue open in the Repository.
  • : Approach is signed off on the issue.

@gauravsaralMs
Copy link
Contributor

[thinking out loud]:
can we support this kind of things (when back compat is breaking and API is not very complex) using command structure similar to invoke?
Invoke will bypass the client requirement so we can still make it work
cc: @atbagga ?

@atbagga
Copy link
Collaborator Author

atbagga commented Apr 8, 2019

[thinking out loud]:
can we support this kind of things (when back compat is breaking and API is not very complex) using command structure similar to invoke?
Invoke will bypass the client requirement so we can still make it work
cc: @atbagga ?

The decision to remove this is taken due to chances of back compat break in the API which is undocumented.
Will forward the email thread to the team.

@atbagga atbagga self-assigned this Apr 8, 2019
gauravsaralMs
gauravsaralMs approved these changes Apr 9, 2019
View reviewed changes
scripts/backCompatChecker.py
oldCommands.append(oldArgument.command)
if oldArgument.command not in ignoreCommands:
if not any(oldArgument.command in s for s in oldCommands):
oldCommands.append(oldArgument.command)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exclude this from
https://github.com/Microsoft/azure-devops-cli-extension/blob/93cae2800ffeb74e55fafbf74777bc3ed8a6913a/scripts/backCompatChecker.py#L87-L90
as well

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was not required.
There were other issues which I fixed.

@atbagga atbagga closed this Apr 9, 2019
@atbagga atbagga reopened this Apr 9, 2019
@atbagga atbagga merged commit 2a7b78e into master Apr 9, 2019
@atbagga atbagga deleted the users/atbagga/taskdefcommands branch April 10, 2019 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gauravsaralMs gauravsaralMs gauravsaralMs approved these changes

@ishitam8 ishitam8 ishitam8 approved these changes

Assignees

@atbagga atbagga

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atbagga @gauravsaralMs @ishitam8