Implement PR checkout #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 25, 2019 17:05
atbagga
reviewed
Mar 26, 2019
| :param id: ID of the pull request. | ||
| :type id: int | ||
| """ | ||
| organization = resolve_instance(detect='on', organization=None) |
There was a problem hiding this comment.
resolve_instance will throw first. User will see "--organization must be specified..." instead of your error if they try from outside a git repo context.
atbagga
approved these changes
Mar 26, 2019
| git_info = get_vsts_info_from_current_remote_url() | ||
| organization = git_info.uri | ||
| if not organization: | ||
| raise CLIError('this command should be used from a valid git repository only') |
There was a problem hiding this comment.
nit: This
Rewording? not just any valid git repository it should be Azure Repo only.
ishitam8
approved these changes
Mar 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure the code is following contribution guidelines in CONTRIBUTING.md
#249