Extension Management Commands #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
March 6, 2019 14:33
atbagga
reviewed
Mar 7, 2019
added 7 commits
March 7, 2019 11:59
ishitam8
approved these changes
Mar 11, 2019
atbagga
reviewed
Mar 11, 2019
| table_row['Name'] = trim_for_display(row['extensionName'], 20) | ||
| table_row['Version '] = trim_for_display(row['version'], 20) | ||
| table_row['Last Updated '] = date_time_to_only_date(row['lastPublished']) | ||
| table_row['States'] = trim_for_display(row['installState']['flags'], 20) |
There was a problem hiding this comment.
Suggest:
Can do more intelligent trimming like add number of flags e.g. 'disabled +2 other'.
Atleast that is how I was planning to do for some pipelines/environment commands.
Open to suggestions even for my own case.
There was a problem hiding this comment.
kind of border line in this case..
even with this info user will have to switch to json view to get the exact string. This will help only when count is a useful information for the user
and I don't think count is a useful information at least in this case..
(this is more of a case to case thing)
atbagga
approved these changes
Mar 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure the code is following contribution guidelines in CONTRIBUTING.md
These are in line with issue #103