Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding wiki and wiki page commands for create, update, show, delete operations #428

Merged
merged 12 commits into from
Apr 3, 2019
Merged

Adding wiki and wiki page commands for create, update, show, delete operations #428

merged 12 commits into from
Apr 3, 2019

Conversation

atbagga
Copy link
Collaborator

@atbagga atbagga commented Feb 7, 2019

Feature: Wiki commands #435

Help Commands output:

image

Create, list, show, delete commands usage:

image

Command help sample (Wiki create command):
image

@atbagga atbagga added the in progress Development in progress label Feb 7, 2019
@atbagga atbagga requested a review from geverghe February 7, 2019 13:00
@atbagga atbagga closed this Feb 7, 2019
@atbagga atbagga reopened this Feb 11, 2019
@atbagga atbagga changed the title Adding wiki Create, list, show, delete commands Adding wiki and wiki page commands for create, update, show, delete operations Feb 14, 2019
@atbagga atbagga removed the in progress Development in progress label Mar 27, 2019
@atbagga
Copy link
Collaborator Author

atbagga commented Mar 27, 2019

@snankani @geverghe Although the corresponding workitem is still under validation this PR was raised much before and was only blocked for 5.0 upgrade since APIs had a breaking change.
This can be reviewed and merged now.

azure-devops/azext_devops/dev/team/_format.py Outdated Show resolved Hide resolved
azure-devops/azext_devops/dev/team/arguments.py Outdated Show resolved Hide resolved
azure-devops/azext_devops/dev/team/arguments.py Outdated Show resolved Hide resolved
azure-devops/azext_devops/dev/team/wiki.py Outdated Show resolved Hide resolved
azure-devops/azext_devops/dev/team/wiki.py Outdated Show resolved Hide resolved
azure-devops/azext_devops/dev/team/wiki.py Outdated Show resolved Hide resolved
azure-devops/azext_devops/dev/team/wiki.py Show resolved Hide resolved
azure-devops/azext_devops/dev/team/wiki.py Outdated Show resolved Hide resolved
:type path: str
:param version: Version of the wiki page.
:type version: str
:param recursion_level: Recursion level of the wiki page.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a bit confused, this is get_page or get_pages 🤣 (due to recursion_level)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also I believe recursion_level has some fixed set of values allowed (please check once) and we can make this an enum

Copy link
Collaborator Author

@atbagga atbagga Apr 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API is same. This is just the wrapped up API so let us discuss this in bash and close how we want the get pages to be exposed.

@atbagga atbagga merged commit 64a4e8f into Azure:master Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants