Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pipeline client 6.0 added to support template parameters for pipelines runs #1211

Merged
merged 63 commits into from
Nov 12, 2021
Merged

Pipeline client 6.0 added to support template parameters for pipelines runs #1211

merged 63 commits into from
Nov 12, 2021

Conversation

roshan-sy
Copy link
Contributor

@roshan-sy roshan-sy commented Oct 7, 2021 •
edited
Loading

Please make sure the code is following contribution guidelines in CONTRIBUTING.md

  • : This PR has a corresponding issue open in the Repository.
  • : Approach is signed off on the issue.

Fixes: #1110

  1. Added pipeline client 6.0,
  2. Added template parameters to the new run command
  3. Command uses v6_0 - PipelinesClient when the "parameter" subcommand is provided.
  4. For the rest use cases it uses v5_0 - BuildClient

Roshan-sy and others added 30 commits July 2, 2021 11:39
Adding example for multiple fields command
2dba759
Duplicate dependencies removed
782fb6f
Internal changes
5b6fd42
Pipeline changes
ed4c075
Merge branch 'master' into Internal
224c0c2
Warning messages added for ADO server
3d95e61
Strip the trailing slash
6d5bacf
run style chagnes
dd0cbff
Merge branch 'Users/Roshan/1151' into Internal
406b6ad
Test cases changes
bcb6c39
1132
f1910e8
Merge branch 'master' into Internal
f7dac16
1132 chnages
a520655
Fixed: Made object id optional
e9d9b9a
Comment changes
9847e21
Merge branch 'Users/Roshan/1132' into Internal
5325b69
run style changes
6de84e9
Merge branch 'master' into Users/Roshan/1132
4955cd0
Merge branch 'Users/Roshan/1132' into Internal
472df75
dlete
684d580
show_command
bde24ae
Merge branch 'master' into Internal
55fa5ce
internal
75c7310
1174
889daf3
sleep_in_live_run = 60
19d770f
sleep time changed for all
b98dbc5
@roshan-sy
Merge branch 'master' into User/Roshan/Internal
ae0c002
@roshan-sy
Merge branch 'master' into User/Roshan/Internal
ceb4240
@roshan-sy
Fixed
1d4b53d
@roshan-sy
None checked
d689b54
@roshan-sy roshan-sy marked this pull request as draft November 9, 2021 10:43
@roshan-sy roshan-sy marked this pull request as ready for review November 12, 2021 05:52
gauravsaralMs
gauravsaralMs suggested changes Nov 12, 2021
View reviewed changes
Copy link
Contributor

@gauravsaralMs gauravsaralMs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please

  • update PR title to show real intent of this PR
  • add more details in the PR like why this change, what is the impact of this change

azure-devops/azext_devops/dev/pipelines/pipeline.py Outdated Show resolved Hide resolved
@roshan-sy roshan-sy changed the title New pipeline client added Pipeline client 6.0 added to support template parameters for pipelines runs Nov 12, 2021
@roshan-sy roshan-sy marked this pull request as draft November 12, 2021 09:24
@roshan-sy roshan-sy marked this pull request as ready for review November 12, 2021 10:31
@roshan-sy roshan-sy merged commit 7146eb1 into master Nov 12, 2021
@roshan-sy roshan-sy deleted the Users/Roshan/1110-2 branch November 12, 2021 10:36
@kaito-ms kaito-ms mentioned this pull request May 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gauravsaralMs gauravsaralMs gauravsaralMs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Allow to set parameters for pipelines runs
2 participants
@roshan-sy @gauravsaralMs