-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
relax ghrepo validation #4237
relax ghrepo validation #4237
Conversation
Folks can define an alias for a hostname to control the usage of different ssh keys. When this happens, the hostname will not be github.com, but it might be still pointing to github. This change relaxes the validation to allow any valid hostname. The command would fail later if the host is not accessible.
Folks can define an alias for a hostname to control the usage of different ssh keys. When this happens, the hostname will not be github.com, but it might be still pointing to github. This change relaxes the validation to allow any valid hostname. The command would fail later if the host is not accessible.
Just wondering - what do you think about keeping the validation as we had before, but in the case where it fails instead prompting the user that the given hostname doesn't look like a github url and ask them if they are sure they want to continue? I'm not sure how this alternate hostname scenario is and if it is worthwhile to throw away all the validation because of it. |
@ellismg , Do you think the validation is giving us some real value here?
That's why I think the validation is not actually helping here. |
Makes sense! |
…ev into relax-ghrepo-validation
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash:
pwsh:
WindowsPowerShell install
MSI install
Standalone Binary
MSI
Documentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference
|
fix: #4185
Relax detection of github host names during azd pipeline config.
Folks can define an alias for a hostname to control the usage of different ssh keys. When this happens, the hostname will not be github.com, but it might be still pointing to github.
This change relaxes the validation to allow any valid hostname. The command would fail later if the host is not accessible.