-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDK 3.39.0: Adds version bump and changelog. #4391
SDK 3.39.0: Adds version bump and changelog. #4391
Conversation
Are contracts changes upto date? The images above shows some contracts/APIs are deleted right? Is that expected? |
I should have checked this. Thanks for pointing it out. |
The changelog doesn't seem to include any query changes - is this intentional? |
Query PRs have been added. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would probably be good to include that the new Taiwan regions are included in Regions.cs
with the Direct Package upgrade in the changelog
I can agree with that. The PR was Internal. Was that a mistake? |
I think normally Direct package upgrades are marked as Internal, but for this upgrade I was unaware of the region changes and that is why it was marked that way. I think we can add something like this to the changelog and link to the direct upgrade PR. Also worth changing our direct upgrade guide to specify this which I will do. |
Ok. @NaluTripician , added the new regions and direct package version update to the changelog. @kirankumarkolli |
@ealsur can you please also take a look? |
03293f5
Pull Request Template
Description
This bumps the SDK GA version from 3.38.1 to 3.39.0 and preview version from 3.39.0-preview.1 to 3.40.0-preview.0. Please see the below changes in the GA public contract.
Also highlighted below are the preview contract changes.
[Note: To understand about the GA and preview versions styles, please take a look at our versioning guidelines and principles]