Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CosmosClientOptions: Adds validation to check DisableServerCertificateValidation and ServerCertificateCustomValidationCallback are set together #4283

Merged
merged 2 commits into from
Jan 30, 2024
Merged

CosmosClientOptions: Adds validation to check DisableServerCertificateValidation and ServerCertificateCustomValidationCallback are set together #4283

merged 2 commits into from
Jan 30, 2024

Conversation

sourabh1007
Copy link
Contributor

@sourabh1007 sourabh1007 commented Jan 26, 2024 •
edited
Loading

Description

As part of this PR, validating DisableServerCertificateValidation flag and ServerCertificateCustomValidationCallback option are set together. Throws ArgumentException if it is true.

Type of change

  • [] Bug fix (non-breaking change which fixes an issue)

@sourabh1007 sourabh1007 changed the title CosmosClientOptions: Adds validation to check HttpFactory and ServerCallback are set together CosmosClientOptions: Adds validation to check HttpFactory and ServerCertificateCustomValidationCallback are set together Jan 26, 2024
NaluTripician
NaluTripician requested changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@NaluTripician NaluTripician left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add some context to the PR description on why both cannot be set. Other than that, LGTM.

@sourabh1007 sourabh1007 changed the title CosmosClientOptions: Adds validation to check HttpFactory and ServerCertificateCustomValidationCallback are set together CosmosClientOptions: Adds validation to check DisableServerCertificateValidation and ServerCertificateCustomValidationCallback are set together Jan 28, 2024
@sourabh1007 sourabh1007 force-pushed the users/sourabhjain/httpfactoryvalidation branch from c7ada36 to 5e94bc7 Compare January 28, 2024 19:57
@sourabh1007 sourabh1007 self-assigned this Jan 28, 2024
@sourabh1007 sourabh1007 added the auto-merge Enables automation to merge PRs label Jan 28, 2024
@kirankumarkolli
Copy link
Member

Lets port this to 3.38 release.

/cc: @kundadebdatta

@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 1bbe101 into master Jan 30, 2024
20 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot deleted the users/sourabhjain/httpfactoryvalidation branch January 30, 2024 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NaluTripician NaluTripician NaluTripician approved these changes

@kirankumarkolli kirankumarkolli kirankumarkolli approved these changes

@khdang khdang Awaiting requested review from khdang khdang is a code owner

@sboshra sboshra Awaiting requested review from sboshra sboshra is a code owner

@adityasa adityasa Awaiting requested review from adityasa adityasa is a code owner

@neildsh neildsh Awaiting requested review from neildsh neildsh is a code owner

@ealsur ealsur Awaiting requested review from ealsur

@FabianMeiswinkel FabianMeiswinkel Awaiting requested review from FabianMeiswinkel FabianMeiswinkel is a code owner

@kirillg kirillg Awaiting requested review from kirillg kirillg is a code owner

Assignees

@sourabh1007 sourabh1007

Labels
auto-merge Enables automation to merge PRs
Projects
Azure Cosmos SDKs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sourabh1007 @kirankumarkolli @NaluTripician