Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent CNS hanging on HNS restart #3343

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: prevent CNS hanging on HNS restart #3343

wants to merge 1 commit into from
+24 −13

Conversation

rbtr
Copy link
Contributor

@rbtr rbtr commented Jan 13, 2025

Reason for Change: Add timeout to HNS service restart so that CNS will fail out instead of hang during init if it gets stuck.

Issue Fixed:

Requirements:

Notes:

@rbtr rbtr requested review from a team as code owners January 13, 2025 22:18
@rbtr rbtr requested review from paulyufan2, Copilot, nddq and ZetaoZhuang and removed request for paulyufan2 January 13, 2025 22:18
Copilot
Copilot AI reviewed Jan 13, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

cns/service/main.go Show resolved Hide resolved
platform/os_windows.go Show resolved Hide resolved
@rbtr rbtr self-assigned this Jan 13, 2025
@rbtr rbtr added cns Related to CNS. fix Fixes something. labels Jan 13, 2025
@rbtr rbtr force-pushed the fix/hns-restart-timeout branch from db85fb6 to bc33abb Compare January 14, 2025 01:21
@rbtr rbtr enabled auto-merge January 14, 2025 16:28
@rbtr
Copy link
Contributor Author

rbtr commented Jan 14, 2025

/azp run Azure Container Networking PR

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rbtr rbtr added this pull request to the merge queue Jan 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 14, 2025
@rbtr rbtr added this pull request to the merge queue Jan 15, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 15, 2025
@rbtr rbtr added this pull request to the merge queue Jan 15, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 16, 2025
@nddq nddq added this pull request to the merge queue Jan 16, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@nddq nddq nddq approved these changes

@ZetaoZhuang ZetaoZhuang Awaiting requested review from ZetaoZhuang

@paulyufan2 paulyufan2 Awaiting requested review from paulyufan2

Assignees

@rbtr rbtr

Labels
cns Related to CNS. fix Fixes something.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rbtr @nddq