Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: ACN PR Pipeline Security Feature Branch #2985

Merged
merged 11 commits into from
Sep 16, 2024
Merged

ci: ACN PR Pipeline Security Feature Branch #2985

merged 11 commits into from
Sep 16, 2024

Conversation

sheylatrudo
Copy link
Contributor

Reason for Change:
Merges change for a PR branch for a OneBranch based pipeline build for Azure Container Networking PR pull request builds. This pipeline will live on the feature branch until the changes have been verified as in-parity, and secure.

Issue Fixed:
Fixes Component Governance alerts for migrating our github repos to use organization compliant builds.

Requirements:

Notes:

@sheylatrudo sheylatrudo requested a review from a team as a code owner September 3, 2024 23:08
@sheylatrudo sheylatrudo requested a review from rjdenney September 3, 2024 23:08
@sheylatrudo sheylatrudo changed the title Feature/ob onboard 0 (feature): ACN PR Pipeline Security Feature Branch Sep 3, 2024
@sheylatrudo
Copy link
Contributor Author

/azp run TriggerCompliantBuild

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sheylatrudo
Copy link
Contributor Author

/azp run TriggerCompliantBuild

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sheylatrudo sheylatrudo changed the title (feature): ACN PR Pipeline Security Feature Branch ci: ACN PR Pipeline Security Feature Branch Sep 4, 2024
@sheylatrudo
Copy link
Contributor Author

/azp run TriggerCompliantBuild

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sheylatrudo
Copy link
Contributor Author

/azp run TriggerCompliantBuild

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sheylatrudo
Copy link
Contributor Author

/azp run TriggerCompliantBuild

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sheylatrudo
Copy link
Contributor Author

/azp run TriggerCompliantBuild

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sheylatrudo
Copy link
Contributor Author

/azp run TriggerCompliantBuild

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sheylatrudo
Copy link
Contributor Author

/azp run TriggerCompliantBuild

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sheylatrudo
Copy link
Contributor Author

/azp run TriggerCompliantBuild

1 similar comment
@sheylatrudo
Copy link
Contributor Author

/azp run TriggerCompliantBuild

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sheylatrudo
Copy link
Contributor Author

/azp run TriggerCompliantBuild

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sheylatrudo
Copy link
Contributor Author

/azp run TriggerCompliantBuild

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

chengch801214
chengch801214 reviewed Sep 12, 2024
View reviewed changes
Copy link
Contributor

@chengch801214 chengch801214 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like a lot of these files are renames, any reason behind that? And are the old files going to be deleted?

@sheylatrudo
Copy link
Contributor Author

@chengch801214 - Yes, this is to prevent collisions with internal pipeline changes to this repo while the feature is being testing. Currently there are multiple workstreams touching these files and we cannot block the higher priority work. Eventually the old files will be deleted after we have confirmed that we have parity across the two versions and we have switched over to using the new pipeline for PR validation.

jpayne3506
jpayne3506 reviewed Sep 12, 2024
View reviewed changes
Copy link
Contributor

@jpayne3506 jpayne3506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing as we are creating new files entirely now, maybe we should move them to .pipelines/devops/* That way we know there is a clear separation between OB and standard yaml pipelines.

.pipelines/trigger.yaml Outdated Show resolved Hide resolved
.pipelines/trigger.yaml Outdated Show resolved Hide resolved
.pipelines/trigger.yaml Show resolved Hide resolved
.pipelines/trigger.yaml Show resolved Hide resolved
.pipelines/singletenancy/dualstack-overlay/dualstackoverlay-e2e.jobs.yaml Show resolved Hide resolved
@sheylatrudo
Copy link
Contributor Author

Seeing as we are creating new files entirely now, maybe we should move them to .pipelines/devops/* That way we know there is a clear separation between OB and standard yaml pipelines.

@jpayne3506 The old files will eventually be deleted after the whole cycle has complete (merge this change -> validation/attain master parity -> merge changes -> add PR check to repo -> run checks side by side for a week -> deprecate old ACN PR Pipeline -> delete replaced files -> merge). It is much better if people have the visibility on these files.

@paulyufan2
Copy link
Contributor

/azp run Azure Container Networking PR

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sheylatrudo
Copy link
Contributor Author

/azp run Azure Container Networking PR

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sheylatrudo sheylatrudo added this pull request to the merge queue Sep 13, 2024
@sheylatrudo
Copy link
Contributor Author

/azp run Azure Container Networking PR

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 14, 2024
@sheylatrudo sheylatrudo added this pull request to the merge queue Sep 14, 2024
@smittal22 smittal22 removed this pull request from the merge queue due to a manual request Sep 14, 2024
@paulyufan2 paulyufan2 added this pull request to the merge queue Sep 15, 2024
Merged via the queue into master with commit 64c6c11 Sep 16, 2024
14 checks passed
@paulyufan2 paulyufan2 deleted the feature/ob-onboard-0 branch September 16, 2024 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chengch801214 chengch801214 chengch801214 left review comments

@jpayne3506 jpayne3506 jpayne3506 approved these changes

@rjdenney rjdenney Awaiting requested review from rjdenney rjdenney is a code owner automatically assigned from Azure/azure-sdn-members

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sheylatrudo @paulyufan2 @chengch801214 @jpayne3506